-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ⌥+⏎ as a shortcut for the verb form #3546
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woot!!
LGTM, but you might want to align this logic with the command palette so we have a consistent approach to handling these shortcuts.
frontend/console/src/features/modules/decls/verb/VerbFormInput.tsx
Outdated
Show resolved
Hide resolved
frontend/console/e2e/cron.spec.ts
Outdated
for (let attempt = 0; attempt < 3; attempt++) { | ||
try { | ||
await page.keyboard.press('ControlOrMeta+Enter') | ||
const responseEditor = page.locator('#response-editor .cm-content[role="textbox"]') | ||
await expect(responseEditor).toBeVisible() | ||
|
||
const responseText = await responseEditor.textContent() | ||
const responseJson = JSON.parse(responseText?.trim() || '{}') | ||
|
||
expect(responseJson).toEqual({}) | ||
break | ||
} catch (error) { | ||
if (attempt === 2) throw error | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bradleydwyer I added this helper to fix the CommandPalette
tests, which might help here too: https://github.com/TBD54566975/ftl/blob/main/frontend/console/e2e/helpers.ts#L27-L35.
You can see how it's used here: https://github.com/TBD54566975/ftl/blob/main/frontend/console/e2e/command-palette.spec.ts#L16-L28
df10a64
to
d7e1eed
Compare
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Wes <[email protected]>
No description provided.