feat: add ⌥+⏎ as a shortcut for the verb form #3546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradleydwyer
requested review from
wesbillman
and removed request for
a team
Open
wesbillman
approved these changes
Nov 27, 2024
frontend/console/src/features/modules/decls/verb/VerbFormInput.tsx
Outdated
Show resolved
Hide resolved
wesbillman
reviewed
Nov 29, 2024
frontend/console/e2e/cron.spec.ts
Outdated
Comment on lines
34
to
48
| for (let attempt = 0; attempt < 3; attempt++) { | ||
| try { | ||
| await page.keyboard.press('ControlOrMeta+Enter') | ||
| const responseEditor = page.locator('#response-editor .cm-content[role="textbox"]') | ||
| await expect(responseEditor).toBeVisible() | ||
|
|
||
| const responseText = await responseEditor.textContent() | ||
| const responseJson = JSON.parse(responseText?.trim() || '{}') | ||
|
|
||
| expect(responseJson).toEqual({}) | ||
| break | ||
| } catch (error) { | ||
| if (attempt === 2) throw error | ||
| } | ||
| } |
There was a problem hiding this comment.
@bradleydwyer I added this helper to fix the CommandPalette tests, which might help here too: https://github.com/TBD54566975/ftl/blob/main/frontend/console/e2e/helpers.ts#L27-L35.
You can see how it's used here: https://github.com/TBD54566975/ftl/blob/main/frontend/console/e2e/command-palette.spec.ts#L16-L28
wesbillman
force-pushed
the
brad/console-verb-shortcut
branch
from
df10a64 to
d7e1eed
Compare
matt2e
pushed a commit
that referenced
this pull request
Dec 10, 2024
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Wes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.