Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ⌥+⏎ as a shortcut for the verb form #3546

Merged
merged 9 commits into from
Dec 9, 2024

Conversation

bradleydwyer
Copy link
Collaborator

No description provided.

@bradleydwyer bradleydwyer requested a review from a team as a code owner November 27, 2024 05:51
@bradleydwyer bradleydwyer requested review from wesbillman and removed request for a team November 27, 2024 05:51
@ftl-robot ftl-robot mentioned this pull request Nov 27, 2024
Copy link
Collaborator

@wesbillman wesbillman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot!!

LGTM, but you might want to align this logic with the command palette so we have a consistent approach to handling these shortcuts.

frontend/console/e2e/cron.spec.ts Outdated Show resolved Hide resolved
frontend/console/e2e/cron.spec.ts Outdated Show resolved Hide resolved
Comment on lines 34 to 48
for (let attempt = 0; attempt < 3; attempt++) {
try {
await page.keyboard.press('ControlOrMeta+Enter')
const responseEditor = page.locator('#response-editor .cm-content[role="textbox"]')
await expect(responseEditor).toBeVisible()

const responseText = await responseEditor.textContent()
const responseJson = JSON.parse(responseText?.trim() || '{}')

expect(responseJson).toEqual({})
break
} catch (error) {
if (attempt === 2) throw error
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wesbillman wesbillman force-pushed the brad/console-verb-shortcut branch from df10a64 to d7e1eed Compare December 9, 2024 19:33
@wesbillman wesbillman merged commit 091f75e into main Dec 9, 2024
96 checks passed
@wesbillman wesbillman deleted the brad/console-verb-shortcut branch December 9, 2024 20:38
matt2e pushed a commit that referenced this pull request Dec 10, 2024
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Wes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants