making config and callbacks not private #186
Merged
+6
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiyoonie9
requested review from
mistermoe,
phoebe-lew,
michaelneale,
KendallWeihe,
ethan-tbd,
tomdaffurn,
diehuxx and
kirahsapong
as code owners
diehuxx
reviewed
Mar 4, 2024
There was a problem hiding this comment.
As I think more about, I'm not sure why we need to expose the callbacks. In fact, we should probably make them private in tbdex-js. We already have setters for the callbacks and "getting" a callback function is something I've never seen before. Not blocking, feel free to go ahead with what seems right to you.
KendallWeihe
approved these changes
Mar 5, 2024
This was referenced Mar 6, 2024
|
@diehuxx hmm... i think that deserves a bit of think. to maintain velocity, i am just gonna merge this for now, but added these tickets for future consideration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.