Protocol spec changes #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This was
linked to
issues
Mar 26, 2024
Closed
Closed
…assing, but test vectors need to be fixed, also need to look at the new regex pattern decimalString and see if it still works with numbers with decimal
jiyoonie9
commented
Mar 30, 2024
There was a problem hiding this comment.
this is what's latest in tbdex main TBD54566975/tbdex@6af20c9
jiyoonie9
requested review from
mistermoe,
phoebe-lew,
michaelneale,
KendallWeihe,
ethan-tbd,
tomdaffurn,
diehuxx,
kirahsapong and
nitro-neal
as code owners
|
ci will fail - to be addressed by #221 |
diehuxx
reviewed
Mar 30, 2024
| } | ||
|
|
||
|
|
||
| @Test | ||
| fun parse_quote() { | ||
| val vector = TestVectors.getVector("parse-quote.json") | ||
| assertNotNull(vector) | ||
| testNonErrorMessageTestVector<Quote>(vector) | ||
| testSuccessMessageTestVector<Quote>(vector) | ||
| } | ||
|
|
||
| @Test | ||
| fun parse_rfq() { |
There was a problem hiding this comment.
For the benefit of other reviews: This is one of the two tests that we expect to fail for this PR. The only other test that should fail is ValidatorTest > validateFailsWithInvalidRfqData(). All other tests should (and do) pass.
Context: #221
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blocked by TBD54566975/tbdex#293 merging