Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit logs: support 'type to locate' in the student name drop-down #11101

Open
damithc opened this issue Apr 12, 2021 · 7 comments
Open

Audit logs: support 'type to locate' in the student name drop-down #11101

damithc opened this issue Apr 12, 2021 · 7 comments
Labels
a-UIX User Interface, User eXperience, responsiveness p.Low Very little impact; unlikely to do in the near future

Comments

@damithc
Copy link
Contributor

damithc commented Apr 12, 2021

image

This drop-down can be quite long. Can we support 'type to locate' ability here?

@damithc damithc added the s.ToDiscuss The issue/PR is undergoing discussion/review by the core team label Apr 12, 2021
@damithc
Copy link
Contributor Author

damithc commented Apr 12, 2021

An alternative is to pop-up a modal containing all students (possibly with more details such as team, email, section etc. -- somewhat similar to what we do in the 'Remind' feature) and advise the user to Ctrl+F to locate the name.

@t-cheepeng
Copy link
Contributor

The modal option makes it seem as if the instructor can search for multiple students?

I think the type to locate would be a more friendly option. Would imagine that a instructor using the page should know the student name he/she wants to search for (if using that filtering option).

@damithc
Copy link
Contributor Author

damithc commented Apr 12, 2021

The modal option makes it seem as if the instructor can search for multiple students?

Depends on the content of the modal.

I think the type to locate would be a more friendly option. Would imagine that a instructor using the page should know the student name he/she wants to search for (if using that filtering option)

Sure, I'm fine with that too.

@t-cheepeng
Copy link
Contributor

@damithc

The typeahead looks something like this
123

Only appears whn > 1 character is typed and maximum of 10 names will appear. Is the 10 name limit okay? Or leave it unbounded?

@damithc
Copy link
Contributor Author

damithc commented Apr 14, 2021

The typeahead looks something like this

I was expecting the dropdown to remain, and allow typing to narrow down the selection. Is that possible? In the end, this is meant to be a choice among options, not a free text entry.

@t-cheepeng
Copy link
Contributor

The easiest way is to use the <datalist> tag. But the issue is that the tag is styled very differently in browsers(which is expected but some browsers style it weirdly) and is buggy in older browsers like safari. See the attached below. Also, bootstrap does not style this tag for us so we cannot fall back on it.

Left: Firefox, right is Chrome. The dropdown arrow is missing in the firefox one but present in chrome
123

We could also manually toggle the dropdown and typing though that will take a while to get up and running

@damithc
Copy link
Contributor Author

damithc commented Apr 15, 2021

Desirable properties, off the top of my head:

  1. User has a way use the dropdown, without having to type anything
  2. User cannot search for something that is not one of the available options
  3. What user types need not be at the start of the name
  4. Case should not matter
  5. There is some indication that the user can type-to-locate

@rrtheonlyone rrtheonlyone self-assigned this May 15, 2021
@damithc damithc added p.Low Very little impact; unlikely to do in the near future and removed s.ToDiscuss The issue/PR is undergoing discussion/review by the core team labels May 23, 2021
@cedricongjh cedricongjh added the a-UIX User Interface, User eXperience, responsiveness label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-UIX User Interface, User eXperience, responsiveness p.Low Very little impact; unlikely to do in the near future
Projects
None yet
Development

No branches or pull requests

4 participants