-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instructor Home Page: Students dropdown buttons of the wrong colour #12657
Comments
Good First Issue - Notes for Contributors Please note that we allow only one We do not assign issues to contributors. If you would like to pick up this issue, do post a comment below to express your interest and check if there is anyone else who is already working on the issue. We will do our best to reply and give you the go-ahead, but if we don't, feel free to submit a PR as long as there is no one else working on it. To get started, do read through our contributing guidelines carefully, and set up a development environment on your local machine before making a PR. If you need any clarifications on our developer guide, or are facing issues that are not found in our troubleshooting guide, please post a message in our discussion forum. |
Hello! I am first time contributor and would like to work on this issue. |
Hi @Mehakpreet9911, sure please go ahead |
okay, so I wanted to checkout the website first. But its not opening(the index.html file). Can you please guide. |
hi @Mehakpreet9911, do follow the guide here: https://teammates.github.io/teammates/setting-up.html to setup your local development environment. If you are running into any further issues, do create a post in discussion |
Hi , Can I take up this issue . I am a beginner and want to contribute |
hey, can I contribute to this issue? |
@SArora12 You may proceed to submit a PR for this issue. @Immortal-codes Please allow @SArora12 to have a go first. Feel free to look at other issues tagged |
Ok
…On Sat, Jan 13, 2024, 6:00 PM Dominic Lim ***@***.***> wrote:
@SArora12 <https://github.com/SArora12> You may proceed to submit a PR
for this issue.
@Immortal-codes <https://github.com/Immortal-codes> Please allow @SArora12
<https://github.com/SArora12> to have a go first. Feel free to look at
other issues tagged good first issue in the meantime!
—
Reply to this email directly, view it on GitHub
<#12657 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A46LGCMEXC2IS5CJSG34MW3YOJ443AVCNFSM6AAAAABARNODECVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJQGQ2DANJQGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@domlimm hey, i am facing some issue in running the project successfully . Can you help me with the set up part? |
okay, no issue @SArora12 |
The buttons in the Students dropdown of a course in the instructor home page are the wrong colour:
This seems to be an unintentional change cause by #12591, in particular the following addition to
styles.scss
:The background colour is being used by another button in another page; moreover, it's unclear why the buttons in the students dropdown is of class
.btn-info
when no other dropdown button has that class (they have.button-light
instead, but even that class seems to be redudant).My suggestion is to simply remove that class from the affected buttons, as well as to ensure that no other buttons are affected. I've taken a quick look and this seems to be the only case, though I might have missed something.
The text was updated successfully, but these errors were encountered: