Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructor Home Page: Students dropdown buttons of the wrong colour #12657

Closed
weiquu opened this issue Dec 12, 2023 · 11 comments · Fixed by #12691
Closed

Instructor Home Page: Students dropdown buttons of the wrong colour #12657

weiquu opened this issue Dec 12, 2023 · 11 comments · Fixed by #12691
Labels
a-UIX User Interface, User eXperience, responsiveness good first issue Easy; restricted for first-time contributors p.VeryLow Just cosmetic value only. Do only if we have spare resources.

Comments

@weiquu
Copy link
Contributor

weiquu commented Dec 12, 2023

The buttons in the Students dropdown of a course in the instructor home page are the wrong colour:

Screenshot 2023-12-12 at 8 36 41 PM

This seems to be an unintentional change cause by #12591, in particular the following addition to styles.scss:

  .btn-info {
    background-color: darken(#0DCAF0, 3%); // 3% darker than info
  }

The background colour is being used by another button in another page; moreover, it's unclear why the buttons in the students dropdown is of class .btn-info when no other dropdown button has that class (they have .button-light instead, but even that class seems to be redudant).

My suggestion is to simply remove that class from the affected buttons, as well as to ensure that no other buttons are affected. I've taken a quick look and this seems to be the only case, though I might have missed something.

@weiquu weiquu added a-UIX User Interface, User eXperience, responsiveness good first issue Easy; restricted for first-time contributors p.VeryLow Just cosmetic value only. Do only if we have spare resources. labels Dec 12, 2023
Copy link

Good First Issue - Notes for Contributors
This issue is for first-time contributors only. If you are new to TEAMMATES, feel free to submit a PR for this issue.

Please note that we allow only one good first issue per contributor. If you have already made a prior contribution to TEAMMATES, you may wish to take a look at issues with the help wanted tag instead.

We do not assign issues to contributors. If you would like to pick up this issue, do post a comment below to express your interest and check if there is anyone else who is already working on the issue. We will do our best to reply and give you the go-ahead, but if we don't, feel free to submit a PR as long as there is no one else working on it.

To get started, do read through our contributing guidelines carefully, and set up a development environment on your local machine before making a PR.

If you need any clarifications on our developer guide, or are facing issues that are not found in our troubleshooting guide, please post a message in our discussion forum.

@Mehakpreet9911
Copy link

Hello! I am first time contributor and would like to work on this issue.

@weiquu
Copy link
Contributor Author

weiquu commented Dec 13, 2023

Hi @Mehakpreet9911, sure please go ahead

@Mehakpreet9911
Copy link

okay, so I wanted to checkout the website first. But its not opening(the index.html file). Can you please guide.

@cedricongjh
Copy link
Contributor

hi @Mehakpreet9911, do follow the guide here: https://teammates.github.io/teammates/setting-up.html to setup your local development environment.

If you are running into any further issues, do create a post in discussion

@SArora12
Copy link
Contributor

SArora12 commented Jan 9, 2024

Hi , Can I take up this issue . I am a beginner and want to contribute

@Immortal-codes
Copy link

Immortal-codes commented Jan 10, 2024

hey, can I contribute to this issue?

@domlimm
Copy link
Contributor

domlimm commented Jan 13, 2024

@SArora12 You may proceed to submit a PR for this issue.

@Immortal-codes Please allow @SArora12 to have a go first. Feel free to look at other issues tagged good first issue in the meantime!

@SArora12
Copy link
Contributor

SArora12 commented Jan 14, 2024 via email

@SArora12
Copy link
Contributor

@domlimm hey, i am facing some issue in running the project successfully . Can you help me with the set up part?

@Immortal-codes
Copy link

okay, no issue @SArora12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-UIX User Interface, User eXperience, responsiveness good first issue Easy; restricted for first-time contributors p.VeryLow Just cosmetic value only. Do only if we have spare resources.
Projects
None yet
6 participants