Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instructor Home Page: Dropdown buttons on mobile #12658

Closed
weiquu opened this issue Dec 12, 2023 · 5 comments · Fixed by #12662
Closed

Instructor Home Page: Dropdown buttons on mobile #12658

weiquu opened this issue Dec 12, 2023 · 5 comments · Fixed by #12662
Labels
a-UIX User Interface, User eXperience, responsiveness good first issue Easy; restricted for first-time contributors p.VeryLow Just cosmetic value only. Do only if we have spare resources.

Comments

@weiquu
Copy link
Contributor

weiquu commented Dec 12, 2023 •
edited
Loading

The dropdown buttons on mobile overflow / are clipped at the edge of the screen.

Example of overflow (note that it extends beyond the full-width footer):
overflow 1

Example of clipping by the side:
overflow 2

(I'm using width 467)

The dropdown should be within the screen width itself.
@weiquu weiquu added a-UIX User Interface, User eXperience, responsiveness good first issue Easy; restricted for first-time contributors p.VeryLow Just cosmetic value only. Do only if we have spare resources. labels Dec 12, 2023
@github-actions GitHub Actions
Copy link

Good First Issue - Notes for Contributors
This issue is for first-time contributors only. If you are new to TEAMMATES, feel free to submit a PR for this issue.

Please note that we allow only one good first issue per contributor. If you have already made a prior contribution to TEAMMATES, you may wish to take a look at issues with the help wanted tag instead.

We do not assign issues to contributors. If you would like to pick up this issue, do post a comment below to express your interest and check if there is anyone else who is already working on the issue. We will do our best to reply and give you the go-ahead, but if we don't, feel free to submit a PR as long as there is no one else working on it.

To get started, do read through our contributing guidelines carefully, and set up a development environment on your local machine before making a PR.

If you need any clarifications on our developer guide, or are facing issues that are not found in our troubleshooting guide, please post a message in our discussion forum.

@Tejasker
Copy link
Contributor

hey , I think I can take up the issue & raise PR once confirmed

@weiquu
Copy link
Contributor Author

weiquu commented Dec 13, 2023

Hi @Tejasker, sure please go ahead!

@Tejasker
Copy link
Contributor

hey @weiquu ,
I too need help in creating a TEAMMATES instance, I have gone through the documentation & followed as instructed but I am not able to create an account TEAMMATES instance and posted this same request in the discussion section too.

@Tejasker Tejasker mentioned this issue Dec 16, 2023
Merged
@Tejasker
Copy link
Contributor

Tejasker commented Dec 16, 2023 •
edited
Loading

Thanks @weiquu
This is my 1st open-source project which I started Contributing to.
Thanks for helping me out when required, glad I successfully made my first contribution, raised PR for it #12662 and hoping it will Merge in the coming future. I am also excited to work on the further issues ahead ;).

Thanks
Tejasker

domlimm added a commit that referenced this issue Dec 24, 2023
@Tejasker @jasonqiu212 @domlimm
[#12658] Instructor Home Page: Dropdown buttons on mobile (#12662)
1915ade 
* fixed changes & made responsive drop down for the indtructor home page

* resolved the issues that are causing test cases that are failing

* resolved the Component testing issues that is causing test cases fail.

* resolved the E2E  testing issues.

* resolved the E2E  testing issues.

* resolved the E2E  testing issues.

* resolved the E2E  testing issues.

* resolved the E2E  testing issues.

* resolved the E2E  testing issues.

* modified & made small adjustments in the code as required

---------

Co-authored-by: Jason Qiu <[email protected]>
Co-authored-by: Dominic Lim <[email protected]>
cedricongjh pushed a commit to cedricongjh/teammates that referenced this issue Feb 20, 2024
@Tejasker @jasonqiu212
@domlimm @cedricongjh
[TEAMMATES#12658] Instructor Home Page: Dropdown buttons on mobile (T…
b341e6e 
…EAMMATES#12662)

* fixed changes & made responsive drop down for the indtructor home page

* resolved the issues that are causing test cases that are failing

* resolved the Component testing issues that is causing test cases fail.

* resolved the E2E  testing issues.

* resolved the E2E  testing issues.

* resolved the E2E  testing issues.

* resolved the E2E  testing issues.

* resolved the E2E  testing issues.

* resolved the E2E  testing issues.

* modified & made small adjustments in the code as required

---------

Co-authored-by: Jason Qiu <[email protected]>
Co-authored-by: Dominic Lim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-UIX User Interface, User eXperience, responsiveness good first issue Easy; restricted for first-time contributors p.VeryLow Just cosmetic value only. Do only if we have spare resources.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#12658] Instructor Home Page: Dropdown buttons on mobile Tejasker/teammates
2 participants
@weiquu @Tejasker