Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructor's Student Records Page: Moderate response button (on panel) #12666

Closed
weiquu opened this issue Dec 16, 2023 · 14 comments · Fixed by #12964
Closed

Instructor's Student Records Page: Moderate response button (on panel) #12666

weiquu opened this issue Dec 16, 2023 · 14 comments · Fixed by #12964
Labels
a-UIX User Interface, User eXperience, responsiveness good first issue Easy; restricted for first-time contributors

Comments

@weiquu
Copy link
Contributor

weiquu commented Dec 16, 2023

Clicking on the "Moderate response" button when the panel is open closes the panel instead of bringing the user to the moderate response page.

Screenshot 2023-12-16 at 4 47 07 PM

In addition, the "Moderate response" button is not clickable via screen reader controls. It just shows up as plain text (seems to be encompassed within the expand panel button):

Screenshot 2023-12-16 at 4 47 43 PM

@weiquu weiquu added a-UIX User Interface, User eXperience, responsiveness good first issue Easy; restricted for first-time contributors labels Dec 16, 2023
Copy link

Good First Issue - Notes for Contributors
This issue is for first-time contributors only. If you are new to TEAMMATES, feel free to submit a PR for this issue.

Please note that we allow only one good first issue per contributor. If you have already made a prior contribution to TEAMMATES, you may wish to take a look at issues with the help wanted tag instead.

We do not assign issues to contributors. If you would like to pick up this issue, do post a comment below to express your interest and check if there is anyone else who is already working on the issue. We will do our best to reply and give you the go-ahead, but if we don't, feel free to submit a PR as long as there is no one else working on it.

To get started, do read through our contributing guidelines carefully, and set up a development environment on your local machine before making a PR.

If you need any clarifications on our developer guide, or are facing issues that are not found in our troubleshooting guide, please post a message in our discussion forum.

@Ragul84
Copy link

Ragul84 commented Dec 17, 2023

I would like to work on this issue. Can i go ahead?

@domlimm
Copy link
Contributor

domlimm commented Dec 17, 2023

Hello @Ragul84, feel free to submit a PR for this!

@00X4447
Copy link

00X4447 commented Dec 31, 2023

Can I contribute to this issue? I'm a first timer.

@cschetan77
Copy link

Hi @weiquu , I'm a first timer, I went through the TEAMMATES application and really liked it.
Wanted to contribute. Already went though the contribution guidelines and have the application up and running in my local.

But was not able to reproduce the issue. However was able to create feedback sessions and get responses on those. Also getting Moderate option but not like what is shown in the image. Gone through help pages, but no luck.

Could you please let me know, what exact steps needs to be performed so I can reproduce it.

@weiquu
Copy link
Contributor Author

weiquu commented Jan 8, 2024

Hi @cschetan77, I assume that you have found the student records page; if not, please log in as an instructor, find a student, and click on All Records (that URL will look something like http://localhost:4200/web/instructor/students/records?courseid=instructor.gma-demo&[email protected]).

After that, scroll down to any panel that has a Moderate response button. When the panel is open, clicking the button closes the panel instead of bringing the user to the moderate response page:

Screen.Recording.2024-01-08.at.9.00.02.PM.mov

The second issue to resolve has to do with the screen reader. You should find out how to enable the screen reader on your computer, and navigate to the button using the screen reader controls.

@cschetan77
Copy link

Thanks @weiquu for prompt response and helping out. Was able to reproduce the issue. Started looking into it.
image

@BusMihail
Copy link

Hi! I took an interest to this project and since I've seen no PRs on this issue I've solved the first problem myself. Unfortunately i can't figure out how to get the screen reader controls going to start working on the 2nd. Any tips? I am on Windows 11.

@cedricongjh
Copy link
Contributor

hi @BusMihail, @cschetan77 is currently working on this issue (do let us know if you're still working on this, otherwise we'll let @BusMihail take up this issue), for our project we strongly suggest not opening PRs until a team member gives the go ahead.

As for your question regarding the screen reader, I do not use Windows 11, but it seems that this guide here: https://www.theverge.com/23317665/windows-11-narrator-screen-reader-how-to-start-keyboard-accessibility might help in activating the screen reader controls for your machine

@cschetan77
Copy link

@cedricongjh sorry got involved somewhere else. Yes I'm looking into it. I was able to solve the button click issue, currently looking into the screen reader one. Will try to post the approach here to proceed. Thanks

@rapiddeveloper22
Copy link

Can I work on this issue

@akash0228
Copy link

can i work on the issuue ?

@eraysozer20
Copy link
Contributor

I would like to work on this issue

@cedricongjh
Copy link
Contributor

hi @eraysozer20, feel free to submit a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-UIX User Interface, User eXperience, responsiveness good first issue Easy; restricted for first-time contributors
Projects
None yet
10 participants