-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instructor's Student Records Page: Moderate response button (on panel) #12666
Comments
Good First Issue - Notes for Contributors Please note that we allow only one We do not assign issues to contributors. If you would like to pick up this issue, do post a comment below to express your interest and check if there is anyone else who is already working on the issue. We will do our best to reply and give you the go-ahead, but if we don't, feel free to submit a PR as long as there is no one else working on it. To get started, do read through our contributing guidelines carefully, and set up a development environment on your local machine before making a PR. If you need any clarifications on our developer guide, or are facing issues that are not found in our troubleshooting guide, please post a message in our discussion forum. |
I would like to work on this issue. Can i go ahead? |
Hello @Ragul84, feel free to submit a PR for this! |
Can I contribute to this issue? I'm a first timer. |
Hi @weiquu , I'm a first timer, I went through the TEAMMATES application and really liked it. But was not able to reproduce the issue. However was able to create feedback sessions and get responses on those. Also getting Moderate option but not like what is shown in the image. Gone through help pages, but no luck. Could you please let me know, what exact steps needs to be performed so I can reproduce it. |
Hi @cschetan77, I assume that you have found the student records page; if not, please log in as an instructor, find a student, and click on All Records (that URL will look something like http://localhost:4200/web/instructor/students/records?courseid=instructor.gma-demo&[email protected]). After that, scroll down to any panel that has a Moderate response button. When the panel is open, clicking the button closes the panel instead of bringing the user to the moderate response page: Screen.Recording.2024-01-08.at.9.00.02.PM.movThe second issue to resolve has to do with the screen reader. You should find out how to enable the screen reader on your computer, and navigate to the button using the screen reader controls. |
Thanks @weiquu for prompt response and helping out. Was able to reproduce the issue. Started looking into it. |
Hi! I took an interest to this project and since I've seen no PRs on this issue I've solved the first problem myself. Unfortunately i can't figure out how to get the screen reader controls going to start working on the 2nd. Any tips? I am on Windows 11. |
hi @BusMihail, @cschetan77 is currently working on this issue (do let us know if you're still working on this, otherwise we'll let @BusMihail take up this issue), for our project we strongly suggest not opening PRs until a team member gives the go ahead. As for your question regarding the screen reader, I do not use Windows 11, but it seems that this guide here: https://www.theverge.com/23317665/windows-11-narrator-screen-reader-how-to-start-keyboard-accessibility might help in activating the screen reader controls for your machine |
@cedricongjh sorry got involved somewhere else. Yes I'm looking into it. I was able to solve the button click issue, currently looking into the screen reader one. Will try to post the approach here to proceed. Thanks |
Can I work on this issue |
can i work on the issuue ? |
I would like to work on this issue |
hi @eraysozer20, feel free to submit a PR |
Clicking on the "Moderate response" button when the panel is open closes the panel instead of bringing the user to the moderate response page.
In addition, the "Moderate response" button is not clickable via screen reader controls. It just shows up as plain text (seems to be encompassed within the expand panel button):
The text was updated successfully, but these errors were encountered: