Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin managing account requests: use spinners to indicate actions in progress #13105

Closed
damithc opened this issue May 1, 2024 · 4 comments · Fixed by #13135
Closed

Admin managing account requests: use spinners to indicate actions in progress #13105

damithc opened this issue May 1, 2024 · 4 comments · Fixed by #13135
Labels
enhancement New feature or request p.Low Very little impact; unlikely to do in the near future

Comments

@damithc
Copy link
Contributor

damithc commented May 1, 2024

V9-0-0-b6, production

Current: When the admin is dealing with account requests (e.g., approving/rejecting/deleting etc.), there is no UI change during the time between clicking a button and result message showing up

Suggested: Use spinners to show some action is in progress, similar to how we use spinners elsewhere in TEAMMATES
@damithc damithc added p.Low Very little impact; unlikely to do in the near future enhancement New feature or request labels May 1, 2024
@Ceaseless04
Copy link

Hi, can I be allowed to work on this feature? I would like to implement the UI change that consists of a spinner to show that the task is in progress.

If possible can you also provide a GIF of how the spinner is used in TEAMMATES?

@Andy-W-Developer
Copy link
Contributor

Hey Ceaseless04,

Here is a spinner example on the Edit Course Details page for instructors.

button_spinner_example.mp4

@Andy-W-Developer
Copy link
Contributor

@Ceaseless04 any updates on this issue?

@damithc
Copy link
Contributor Author

damithc commented May 27, 2024

Here is a spinner example on the Edit Course Details page for instructors.
https://github.com/TEAMMATES/teammates/assets/128531452/3a10b4f5-5341-460b-94c4-f61f4727d15a

@Andy-W-Developer Thanks for providing this example.
@Ceaseless04 to add, here's where the spinner appears:
image

@Respirayson Respirayson mentioned this issue Jun 23, 2024
Merged
domoberzin pushed a commit that referenced this issue Jul 1, 2024
@Respirayson
[#13105] Admin managing account requests: use spinners to indicate ac…
b402863 
…tions in progress (#13135)

* Add spinners for approve, reject and reset in account-request-table

* Add spinners to regenerate keys in admin-search-page

* Update spinners in account-request-table to work individually

* Update tests

* Update buttons to be disabled while loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request p.Low Very little impact; unlikely to do in the near future
Projects
None yet
Milestone
No milestone
3 participants
@damithc @Ceaseless04 @Andy-W-Developer