-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#12283] Instructor view session results (course-wide): Add separate button to download results by question #12591
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @MaharshiPedu thank you for your PR!
Just a small thing, I think we should remove the download functionality from the question number
Personally, the color contrast between the Upon further inspection of the example above, I realized that the background color of
To maintain consistency with existing dropdown panels, I tested out darkening the background color of Why 3%?
@cedricongjh What do you think? |
I think you are right about the contrast between the Suggestion: If we look at consistency, then the chevron should also be of the same color as the other text inside the panel like in the ones below: So, the chevron in the questions panel should also be black as the text inside that panel is black, like so: |
Yup I agree with the points raised here! Good catch @jasonqiu212 and @MaharshiPedu. Another thing I would like to suggest is that we should change the text from "Download" to "Download Results" as this will probably make it clearer to the user what the button is for before they mouse over it (and will then see the tooltip), what do you all think? |
@cedricongjh I agree! To keep it consistent with the other panels, I think changing the text to "Download Results" and removing the tool tip is a great idea. |
17a817e
to
222086c
Compare
@cedricongjh @jasonqiu212 Now, I am having trouble finding out the reason for the failing component tests. Would highly appreciate any help. |
Hi @MaharshiPedu, I believe some of the snapshot tests are failing after the chevron color change. To update to update the snapshot tests, run |
I have updated the snapshots. Please have a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for the work on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MaharshiPedu Just one more small nit!
...ructor/instructor-session-result-page/instructor-session-result-question-view.component.html
Outdated
Show resolved
Hide resolved
@cedricongjh Upon further inspection, after this merge, the input Since the tooltip download feature is not UI friendly, do you think we should just remove the input and feature altogether? I think all future features to download something should be only done through an explicit button. |
@jasonqiu212 i agree! let's create a new issue to remove the code completely, or if @MaharshiPedu likes, can remove it as part of this PR as well |
I agree! I could do these changes as part of this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for contributing to TEAMMATES!
Fixes #12283
Outline of Solution
I have added a button that downloads question results on the right side near expand tab button.
I have used the same design that 👇🏽 follows.