Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(top-menu): Replace the banner by the news #1409

Open
4 tasks
WaDadidou opened this issue Nov 22, 2024 · 4 comments · May be fixed by #1417
Open
4 tasks

fix(top-menu): Replace the banner by the news #1409

WaDadidou opened this issue Nov 22, 2024 · 4 comments · May be fixed by #1417
Assignees
@apoorvapendse
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers UX/UI

Comments

@WaDadidou
Copy link
Collaborator

WaDadidou commented Nov 22, 2024 •
edited
Loading

Bellow, Here is a screenshot of the Home screen with the TopMenu open.
In the TopMenu, at "Highlighted News", the Home banner is shown instead of the news, that's wrong.
The news to use are the same data than on the Home page: https://github.com/TERITORI/teritori-dapp/blob/chore-thumbnail-media/packages/components/carousels/NewsCarouselSection.tsx#L22

You have to :

Take attention to the existing components before making new ones, and ask information if you need :)

Image

  • Red: Current wrong state
  • Green: What it should be
@WaDadidou WaDadidou added bug Something isn't working enhancement New feature or request good first issue Good for newcomers UX/UI labels Nov 22, 2024
@Dhir0808
Copy link
Contributor

Hello WaDadidou, I would like to take this issue.

@apoorvapendse
Copy link

Hey @Dhir0808,
I started working on this issue already.
Could you please assign some other issue to yourself?
Thanks.

@WaDadidou
Copy link
Collaborator Author

WaDadidou commented Nov 25, 2024 •
edited
Loading

Hello @apoorvapendse It could be tricky, but if you are not affraid of our front, let's try :)
When it's done, make a PR and mention this issue

@apoorvapendse apoorvapendse linked a pull request Nov 25, 2024 that will close this issue
Open
@apoorvapendse
Copy link

apoorvapendse commented Nov 25, 2024 •
edited
Loading

Hey @WaDadidou, I have created a Pull Request.
Thanks for the opportunity.
Looking forward to your feedback 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apoorvapendse apoorvapendse

Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers UX/UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Replace home banner with news carousel. apoorvapendse/teritori-dapp
3 participants
@WaDadidou @Dhir0808 @apoorvapendse