Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate retrieve_search_results() input #78

Open
1 task
katrinleinweber opened this issue May 21, 2018 · 1 comment
Open
1 task

Validate retrieve_search_results() input #78

katrinleinweber opened this issue May 21, 2018 · 1 comment
Labels
enhancement good first issue question
Milestone
ROpenSci

Comments

@katrinleinweber
Copy link
Collaborator

katrinleinweber commented May 21, 2018 •
edited
Loading

Right below https://github.com/TIBHannover/BacDiveR/blob/master/R/retrieve_search_results.R#L14, the queryURL should be validated ("defensive programming") somehow. Maybe using stringi::stri_startswith("https://bacdive.dsmz.de/advsearch?site=advsearch") and/or stringi::stri_endswith("&advsearch=search")?

In either case, a test should be added whether an error is triggered by using a non-advsearch URL.
@katrinleinweber katrinleinweber added this to the FAIR Data & Software milestone May 21, 2018
@katrinleinweber
Copy link
Collaborator Author

Related to #71.

katrinleinweber added a commit that referenced this issue Nov 19, 2018
@katrinleinweber
Validate inputs (fix #71 & #78)
05bacc2 
Validate inputs (fix #71 & #78)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue question
Projects
None yet
Milestone
ROpenSci
Development

No branches or pull requests
1 participant
@katrinleinweber