Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArchUnit does not load the names of referenced assemblies for dependent / recursively loaded assemblies #311

Open
made-by-karl opened this issue Oct 10, 2024 · 0 comments · May be fixed by #319
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@made-by-karl
Copy link

ArchLoader.LoadModule() sets the name of referenced assemblies only for the requested assembly, not for other loaded assemblies.

I think you can retrieve this data from an AssemblyDefinition via the MainModule.AssemblyReferences property, so instead of calling
_archBuilder.AddAssembly(assemblyDefinition, false, null) you could set the referenced assembly names inside of the AddAssembly() method.

I'd like to open a PR for this issue.

made-by-karl added a commit to made-by-karl/ArchUnitNET that referenced this issue Oct 25, 2024
made-by-karl added a commit to made-by-karl/ArchUnitNET that referenced this issue Oct 25, 2024
made-by-karl added a commit to made-by-karl/ArchUnitNET that referenced this issue Oct 25, 2024
@alexanderlinne alexanderlinne added the kind/bug Categorizes issue or PR as related to a bug. label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants