fill the ReferencedAssemblyNames property for all loaded assemblies #311 #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
made-by-karl
force-pushed
the
referencedAssemblyNames
branch
from
d9bf4cc
to
fbdec12
Compare
Fixes issue TNG#311 Signed-off-by: Karl Rhenius <[email protected]>
made-by-karl
force-pushed
the
referencedAssemblyNames
branch
from
fbdec12
to
7bb008e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #319 +/- ##
=======================================
Coverage 65.43% 65.44%
=======================================
Files 256 256
Lines 22946 22946
Branches 1949 1948 -1
=======================================
+ Hits 15015 15016 +1
+ Misses 7378 7377 -1
Partials 553 553 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
Hi @made-by-karl, thank you for your PR. Could you fix the code formatting? I've already created another PR that will fix the issue with the windows build |
fixes code formatting Signed-off-by: Karl Rhenius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ArchBuilder always adds the names of referenced assemblies from the AssemblyDefinition.MainModule.AssemblyReferences property.
Resolves #311
Signed-off-by: Karl Rhenius [email protected]