Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Deleting Tags Doesn’t Remove Reference to Disambiguation Tag ID #768

Open
3 tasks done
CyanVoxel opened this issue Feb 2, 2025 · 0 comments
Open
3 tasks done
Labels
Priority: High An important issue requiring attention TagStudio: Library Relating to the TagStudio library system Type: Bug Something isn't working as intended

Comments

@CyanVoxel
Copy link
Member

CyanVoxel commented Feb 2, 2025

Checklist

  • I am using an up-to-date version.
  • I have read the documentation.
  • I have searched existing issues.

TagStudio Version

Alpha v9.5.0 Pre-Release 1

Operating System & Version

macOS 15.1.1

Description

When deleting a tag that is used as a parent tag on another tag and is set as its disambiguation tag, the disambiguation_id of any child tags is not cleared. This results in child tags displaying as "<NO DISAM TAG>".

Expected Behavior

When a tag used for disambiguation is deleted, it should also remove any references of itself from any child tags in the disambiguation_id column of the tags table.

Furthermore, any existing libraries that hold references to tags that have been deleted should be updated and corrected.

Steps to Reproduce

  1. Create a tag "Tag1"
  2. Create a tag "Tag2"
  3. Add Tag2 as a parent tag to Tag1, and check the "use for disambiguation" box next to it. Tag1 should now display as "Tag1 (Tag2)"
  4. Delete Tag2 from the Tag Manager
  5. Observe how Tag1 is now displayed as "<NO DISAM TAG>"

Logs

N/A

@CyanVoxel CyanVoxel added Priority: High An important issue requiring attention TagStudio: Library Relating to the TagStudio library system Type: Bug Something isn't working as intended labels Feb 2, 2025
@CyanVoxel CyanVoxel added this to the Alpha v9.5 (Post-SQL) milestone Feb 2, 2025
@CyanVoxel CyanVoxel moved this to 🛠 Ready for Development in TagStudio Development Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High An important issue requiring attention TagStudio: Library Relating to the TagStudio library system Type: Bug Something isn't working as intended
Projects
Status: 🛠 Ready for Development
Development

No branches or pull requests

1 participant