Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: App freezes after one image switch due to open_explorer_action signal connection #831

Open
3 tasks done
albinwwoxnerud opened this issue Mar 5, 2025 · 2 comments
Labels
System: macOS For the macOS operating system Type: Bug Something isn't working as intended

Comments

@albinwwoxnerud
Copy link

Checklist

  • I am using an up-to-date version.
  • I have read the documentation.
  • I have searched existing issues.

TagStudio Version

9.5.0-pre4

Operating System & Version

macOS, 15.3.1, 24D70

Description

When running the app directly with Python, I can open one image and switch to another once. After that, the app locks up and doesn’t allow any further interaction except favoriting via the UI star element.

Issue:

The issue is in tagstudio/src/qt/widgets/preview/preview_thumb.py, specifically in update_preview. The line that causes the lockup:

self.open_explorer_action.triggered.connect(self.opener.open_explorer)

It looks like QAction.triggered emits a boolean, which doesn’t match the expected signature of open_explorer, leading to the UI freezing.

Fix:

Changing the connection to use a lambda prevents the issue:

self.open_explorer_action.triggered.connect(lambda checked=False: self.opener.open_explorer())

This made switching work as expected for me.

I have a PR ready if this is confirmed to be a general issue and not something specific to my setup.

Expected Behavior

It should allow switching between images without restrictions.

Steps to Reproduce

  1. Open TagStudio
  2. Open a folder of JPEGs
  3. Open one image
  4. Switch to another image
  5. Application freezes

Logs

No logs due to freeze

@albinwwoxnerud albinwwoxnerud added the Type: Bug Something isn't working as intended label Mar 5, 2025
@CyanVoxel
Copy link
Member

I'm also on macOS 15 and have not encountered or been able to replicate this issue.

When running the app directly with Python

Normally I would assume you meant that you ran the current git version from a development environment, but saying that you're on version 9.5.0-pre4 confuses me a bit. How is it exactly that you're running the program? Are you pulling from the repo or using one of the macOS app releases?

@CyanVoxel CyanVoxel added the System: macOS For the macOS operating system label Mar 5, 2025
@albinwwoxnerud
Copy link
Author

Hello,

I apologize for any confusion. I based my version number on the pyproject.toml file, which was recently updated to version "9.5.0". I was actually using 9.5.0, but I incorrectly stated it as 9.5.0-pre4.

I am running the development version from the main branch. Sorry again for the mix-up, and I appreciate your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
System: macOS For the macOS operating system Type: Bug Something isn't working as intended
Projects
None yet
Development

No branches or pull requests

2 participants