fix(FormApi): clear onMount validation errors

Clear the `onMount` validation errors when the next validation is
performed.

Author: bpinto

packages/form-core/src/FormApi.ts

@@ -1451,16 +1451,18 @@ export class FormApi<
 
           if (
             // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
-            currentErrorMap?.[errorMapKey] !== newErrorValue
+            currentErrorMap?.[errorMapKey] !== newErrorValue || (currentErrorMapSource?.onMount === 'form' && validateObj.cause !== 'server')
           ) {
             this.setFieldMeta(field, (prev) => ({
               ...prev,
               errorMap: {
                 ...prev.errorMap,
+                onMount: undefined,
                 [errorMapKey]: newErrorValue,
               },
               errorSourceMap: {
                 ...prev.errorSourceMap,
+                onMount: undefined,
                 [errorMapKey]: newSource,
               },
             }))

packages/form-core/tests/FormApi.spec.ts

@@ -2986,6 +2986,88 @@ describe('form api', () => {
     expect(interestsField.state.meta.errors).toStrictEqual([])
   })
 
+  it("clears form's onMount validation field errors on next form validation", async () => {
+    const form = new FormApi({
+      defaultValues: {
+        firstName: '',
+        middleName: '',
+        lastName: '',
+      },
+      validators: {
+        onChange: ({ value }) => {
+          return {
+            fields: {
+              firstName: value.firstName !== 'john' ? 'first name is not john' : null,
+              lastName: 'last name is required',
+            }
+          }
+        },
+        onMount: () => {
+          return {
+            fields: {
+              firstName: 'first name is required',
+              lastName: 'last name is required',
+            }
+          }
+        },
+      },
+    })
+
+    const firstNameField = new FieldApi({
+      form,
+      name: 'firstName',
+    })
+
+    const middleNameField = new FieldApi({
+      form,
+      name: 'middleName',
+      validators: {
+        onMount: () => 'middle name is required',
+      },
+    })
+
+    const lastNameField = new FieldApi({
+      form,
+      name: 'lastName',
+    })
+
+    firstNameField.mount()
+    middleNameField.mount()
+    lastNameField.mount()
+    form.mount()
+
+    expect(firstNameField.state.meta.errorMap.onMount).toBe('first name is required')
+    expect(firstNameField.state.meta.errorSourceMap.onMount).toBe('form')
+
+    expect(middleNameField.state.meta.errorMap.onMount).toBe('middle name is required')
+    expect(middleNameField.state.meta.errorSourceMap.onMount).toBe('field')
+
+    expect(lastNameField.state.meta.errorMap.onMount).toBe('last name is required')
+    expect(lastNameField.state.meta.errorSourceMap.onMount).toBe('form')
+
+    firstNameField.setValue('other')
+
+    expect(firstNameField.state.meta.errorMap.onChange).toEqual('first name is not john')
+    expect(firstNameField.state.meta.errorSourceMap.onMount).toBeUndefined()
+
+    expect(middleNameField.state.meta.errorMap.onMount).toBe('middle name is required')
+    expect(middleNameField.state.meta.errorSourceMap.onMount).toBe('field')
+
+    expect(lastNameField.state.meta.errorMap.onMount).toBeUndefined()
+    expect(lastNameField.state.meta.errorSourceMap.onMount).toBeUndefined()
+
+    firstNameField.setValue('john')
+
+    expect(firstNameField.state.meta.errorMap.onMount).toBeUndefined()
+    expect(firstNameField.state.meta.errorSourceMap.onMount).toBeUndefined()
+
+    expect(middleNameField.state.meta.errorSourceMap.onMount).toBe('field')
+    expect(middleNameField.state.meta.errorMap.onMount).toBe('middle name is required')
+
+    expect(lastNameField.state.meta.errorMap.onMount).toBeUndefined()
+    expect(lastNameField.state.meta.errorSourceMap.onMount).toBeUndefined()
+  })
+
   it('should not change the onBlur state of the fields when the form is submitted', async () => {
     const form = new FormApi({
       defaultValues: {