Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search filter should exclude column names #11

Open
shoebaamir7 opened this issue Aug 10, 2021 · 0 comments
Open

Search filter should exclude column names #11

shoebaamir7 opened this issue Aug 10, 2021 · 0 comments

Comments

@shoebaamir7
Copy link

In function getFilteredList() in file selectors.js,
This line
if (searchValue != null && searchValue !== '' && show) {
show =
JSON.stringify(row)
.toUpperCase()
.indexOf(String(searchValue).toUpperCase()) !== -1
}

Here row is an object which contains column name as key and it's value as value. Now when we stringify this object, it will include column names as well in the created string. Ideally the the search filter should be applicable to row values and not column names.

@shoebaamir7 shoebaamir7 changed the title Search filter include column names Search filter should exclude column names Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant