Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angela is copying the KIT for each test #12

Closed
mathieucarbou opened this issue Feb 18, 2020 · 4 comments
Closed

Angela is copying the KIT for each test #12

mathieucarbou opened this issue Feb 18, 2020 · 4 comments
Assignees
Labels

Comments

@mathieucarbou
Copy link
Member

With the infra we had before, we didn't need to copy the KIT.

The KIT files were copied by gradle and then we were created one working directory per test using these KIT files.

The only file that could be moved to the KIT was the logback-ext.xml file for the logging. But this file is places in the test/resources folder and then could be considered common to all tests and we then could create a KIT one time with this file and reuse the same KIT files for all the tests, as long as the working directories are not the same.

This would help improve the work dir size and test speed (#10 and #11)

@aurbroszniowski
Copy link
Member

The reason why it copies the kit is for test isolation, the copy itself is supposed to be negligible.
A review of the current logic is needed, there might have been an issue introduced during the refactoring of pulling common install code in a new KitUtils class

@saurabhagas
Copy link

I think the problem here is not of speed, but of space. The duplicate kits can occupy a lot of unnecessary space on failed tests in PRs. What we could do is preserve only the test data once a test has failed, instead of preserving the entire work directory for the test.

@saurabhagas
Copy link

Completed.

@mathieucarbou
Copy link
Member Author

@aurbroszniowski : we should adapt Angela tp be able to get what was possible with Galvan. Galvan was copying the kit before and it was creating space issues in jenkins nodes, regardless whether tests were failing or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants