Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test controller: Fail test when tox fails #28

Open
The-Compiler opened this issue Jul 8, 2022 · 0 comments
Open

test controller: Fail test when tox fails #28

The-Compiler opened this issue Jul 8, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@The-Compiler
Copy link
Owner

Currently, running tox via the test controller makes the test pass immediately, even if tox is still running, or even failed:

image

We should attempt to actually get the tox exit status, and show the test as running/passed/failed correctly.

Unfortunately, I'm not quite sure to what extent that's possible with the API we get from VS Code, as long as we still want to run the command in the terminal... Maybe we could use tasks there and listen to onDidEndTaskProcess?

cc @starlord-daniel
@The-Compiler The-Compiler added the enhancement New feature or request label Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@The-Compiler