Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate primary_network_interface config parameter #86

Open
BytePaws opened this issue Oct 17, 2024 · 0 comments
Open

Deprecate primary_network_interface config parameter #86

BytePaws opened this issue Oct 17, 2024 · 0 comments
Labels
accepted this proposal was accepted configuration This issue is linked to the application configuration

Comments

@BytePaws
Copy link
Member

Proposed Changes

Remove the requirement for the user to specify a network interface as primary.
A primary network interface should be automatically identified by being:

  1. Up
  2. Connected
  3. Not set to management only?

Justification

The primary_network_interface config parameter - which is not documented since rewriting the config_parser module with #83 - is currently required for payload translation.
An effort should be made to patch that field for the specific device after registering all of its interfaces.

Impact

The impact for users would be minimal. They would not be required to decide which of the devices interfaces (which can fluctuate in names or number) should be primary.

@BytePaws BytePaws added pending waiting for maintainer approval accepted this proposal was accepted configuration This issue is linked to the application configuration and removed pending waiting for maintainer approval labels Oct 17, 2024
@BytePaws BytePaws added this to the Half Way Point v0.5.0 milestone Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted this proposal was accepted configuration This issue is linked to the application configuration
Projects
Status: No status
Development

No branches or pull requests

1 participant