Add player movement code #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiniaczQ
reviewed
Jul 8, 2024
MiniaczQ
reviewed
Jul 8, 2024
MiniaczQ
reviewed
Jul 8, 2024
MiniaczQ
reviewed
Jul 8, 2024
Co-authored-by: MiniaczQ <[email protected]>
MiniaczQ
reviewed
Jul 8, 2024
MiniaczQ
reviewed
Jul 8, 2024
Co-authored-by: MiniaczQ <[email protected]>
MiniaczQ
reviewed
Jul 8, 2024
Co-authored-by: MiniaczQ <[email protected]>
MiniaczQ
approved these changes
Jul 8, 2024
benfrankel
requested changes
Jul 8, 2024
benfrankel
requested changes
Jul 8, 2024
benfrankel
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted from bevyengine/bevy#14223
Resolves #10
Resolves #11
I'm intentionally using
FixedUpdatehere instead of a very minimal example since I expect many jam submissions to do some kind of player movement, so it's best to show them how it's done correctly right away.I also moved the level spawning away from screen because that's a game detail and not a screen transition detail.
The input is not nicely abstracted away because when I started doing that, I noticed I was basically reimplementing LWIM. Better to just link to that imo.
I know that @benfrankel said that physics go in
core, but I intentionally placed them ingamehere because I expect the physics handling to be vastly different from game to game and I want to make it obvious to users that they are encouraged to change the implementation according to their needs. The rest ofcoreis comparatively tame; I expect many will leave most of it untouched.