Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with react-router v7 #32

Open
steven-resonance opened this issue Dec 3, 2024 · 4 comments
Open

Not compatible with react-router v7 #32

steven-resonance opened this issue Dec 3, 2024 · 4 comments

Comments

@steven-resonance
Copy link

Describe the bug

As I was upgrading from remix v2.x to react-router v7, I hit an error with remix-auth-socials:

Could not resolve "@remix-run/server-runtime"

remix-auth v4 is compatible with both Remix v2 and react-router v7. I can attempt a PR if that will help.

Thanks!

Your Example Website or App

n/a

Steps to Reproduce the Bug or Issue

  1. In any Remix v2 app using remix-auth-socials, follow steps to upgrade/migrate to React Router v7
  2. Attempt to run the app using npm run dev
  3. Observe multiple import errors: Could not resolve "@remix-run/server-runtime"

Expected behavior

I expect/hope that this package can be made compatible with both Remix v2 and React Router v7

Screenshots or Videos

No response

Platform

  • OS: [e.g. macOS, Windows, Linux]
  • Browser: [e.g. Chrome, Safari, Firefox]
  • Version: [e.g. 91.1]

Additional context

No response

@TheRealFlyingCoder
Copy link
Owner

Hey hey,

As with any version upgrade like this, we need all the re-exported packages to make the switch first.

I'll start putting issues on them

@TheRealFlyingCoder
Copy link
Owner

Following up with the issue links - I'll try and keep track of things as they update if I can:

remix-auth-github ✅

remix-auth-microsoft ✅

remix-auth-discord

remix-auth-facebook

remix-auth-google

remix-auth-linkedin

remix-auth-twitter

@TheRealFlyingCoder
Copy link
Owner

A note is that some haven't seen activity for >1yr and might not be monitored by their creators anymore... It was the main potential issue with collating packages like this.

If we don't see any movement on them after a couple weeks the only option is to have the code for each internally managed again 🤷

If you have the time @steven-resonance maybe just send PR's for the packages you care about to help them get up to the right version.

I'd be fine to push a V3 that has a mix of internally managed code as well if you want to do a PR here. Once the real packages get updated they could be switched back over to externally managed.

@steven-resonance
Copy link
Author

Thanks for the update! It looks like upgrading to remix-auth v4 is a bigger task than I expected. The package I most urgently need is remix-auth-google, so I will look at putting up a PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants