Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on startup on High Sierra #29

Open
gilsonolegario opened this issue Sep 28, 2017 · 26 comments
Open

Crash on startup on High Sierra #29

gilsonolegario opened this issue Sep 28, 2017 · 26 comments

Comments

@gilsonolegario
Copy link

gilsonolegario commented Sep 28, 2017

In the new macOS High Sierra the Theremin.app crash just after it starts.

There is something broken with the playback controls
[mWindow setToolbar:[_mainPlayerToolbarController toolbar]];

If the source code are compiled without the playback buttons everything is fine. But, of course, without the buttons on the toolbar.

@gilsonolegario gilsonolegario changed the title Crash on startup Crash on startup on High Sierra Sep 28, 2017
@therealmuffin
Copy link

therealmuffin commented Sep 28, 2017 via email

@gilsonolegario
Copy link
Author

Thanks for your suggestion. I know Cantata, but it consumes ~7% of CPU and ~80% more memory than Theremin. As I said, I compiled a version with no playback controls and I will live with that.

Thanks.

@musyne
Copy link

musyne commented Oct 12, 2017

Can you share your compiled version?
I just updated to high sierra and I already miss Theremin :(

@gilsonolegario
Copy link
Author

gilsonolegario commented Oct 12, 2017

Oh, great! I'm not the only one.

Of course, but as I said, it's only partially working.

https://drive.google.com/open?id=0B3pkQ71JfgdTTmVRRkc2X0FON3M

@musyne
Copy link

musyne commented Oct 17, 2017

We might be the only 2!

@mkody
Copy link

mkody commented Oct 17, 2017

Well, I've been waiting to see if there was a fix but your version do work.
Thanks!

@saundersjr
Copy link

I too would like a fix.

@acy76
Copy link

acy76 commented Dec 17, 2017

You all are not alone. I would also love a fixed version, but I am a PHP dev and couldn't even get xcode to compile when I took a shot at a fix the other week. I confess to knowing next to nothing about mac os development, but I would be willing to assist in fixing this app. If anyone has resources, advice or wants to collaborate, please let me know.

@rgolan
Copy link

rgolan commented Dec 17, 2017

I'm experiencing the same crash on startup. I too would willing to help test fixes.

@gilsonolegario
Copy link
Author

There is https://github.com/kampfgnu/Theremin/commits/master
but is crashing here too

@rgolan
Copy link

rgolan commented Dec 17, 2017

@gilsonolegario : I really can't debug this but I can test as I mentioned. I installed your version without the playback buttons as I ususally use the keyboard shortcuts anyway. It appears kampfgnu is working on Theremin right now. Hopefully there will be a compiled version to test soon.

@kampfgnu
Copy link

try this: https://drive.google.com/file/d/17btcu5Dx9GU4yaQjYUostqLvO5OQqHz8/view?usp=sharing
it is the compiled version of my master branch. i think it fixes the toolbar crash

@gilsonolegario
Copy link
Author

Thanks for you response, @kampfgnu.

Your version crashes with

Crashing on exception: -[UnifiedToolbarLabelCell _compressibleOptionsForControlView:]: unrecognized selector sent to instance 0x60400011a8b0

@kampfgnu
Copy link

kampfgnu commented Dec 20, 2017

i'm running on sierra, so it is currently not possible for me to check this.
but just add the function to UnifiedToolbarLabelCell.m file like i did for another toolbar crash:

  • (BOOL)_anySegmentShowsBadge {
    return NO;
    }
  • (BOOL) _compressibleOptionsForControlView {
    return NO;
    }

i am not sure, if compressibleOptions... returns a BOOL, but just add the missing functions to this file. this should fix it.

cheers!

@gilsonolegario
Copy link
Author

gilsonolegario commented Dec 20, 2017

only adding the function to UnifiedToolbarLabelCell.m doesn't work. But your commit solves the problem.

Many thanks!

@rgolan
Copy link

rgolan commented Dec 20, 2017 via email

@gilsonolegario
Copy link
Author

Here @rgolan

@rgolan
Copy link

rgolan commented Dec 20, 2017 via email

@khgantz
Copy link

khgantz commented Feb 4, 2018

Thank you! As a non programmer I had almost given up on a fix for Theremin. I use it to play stuff on antique radios that I've gutted and converted to Raspberry Pi music players. Examples are at https://youtu.be/6aU0hzXlWcU and https://youtu.be/SG2tHZRswO8 . Now, if only someone would fix mpod for iOS .. :-)

Again, thank you very much!

@kampfgnu
Copy link

kampfgnu commented Feb 5, 2018

btw. i added the current build here: https://github.com/kampfgnu/Theremin/releases
any future updates will be released over there.

@khgantz i just sent an email to the guy who created mPod, offering him my help to get the app up and running. let's see if this will work out.

i keep you posted, cheers!

@khgantz
Copy link

khgantz commented Feb 5, 2018 via email

@trafferty
Copy link

Thanks @kampfgnu !!

@opfeifer
Copy link

Awesome! So great someone still cares for this. Running fine here on High Sierra 10.13.4!

@vbalien vbalien mentioned this issue Jun 14, 2018
@rabb1t
Copy link

rabb1t commented May 3, 2019

Thanks @kampfgnu! Runs smoothly on macOS Mojave v10.14.3!

@bobbygeewow
Copy link

Yes!
Thank you also kampfgnu!

@herrernst
Copy link

Unfortunatley, @kampfgnu's build also crashes for me on macOS Catalina:
Assertion failed: (_eventPort != NULL), function -[SPMediaKeyTap startWatchingMediaKeys], file /Users/kampfgnu /Documents/Programming/OSX_projects/Theremin/ThereminFork/Source/SPMediaKeyTap/SPMediaKeyTap.m, line 76.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests