RegisterSerializer has a 'get_cleaned_data' method that sets undefined fields to empty strings

[ardenn]

Hi, I just noticed something weird with the RegisterSerializer. It has a get_cleaned_data method that seems to assign empty strings to fields whose values haven't been passed during registration. For instance, if I choose to register without a password1 value, then the all-auth adapter sets the password using set_unusable_password().

Presently am working on a project that requires users to be registered without passwords (i.e set_unusable_password() ). So I had to override get_cleaned_data method to make sure password1 is None instead of an empty string.

Shouldn't this be the default implementation? (my thoughts)

class RegisterSerializer(serializers.Serializer):
    ...
   def get_cleaned_data(self):
        return {
            'username': self.validated_data.get('username', ''),
            'password1': self.validated_data.get('password1', ''),
            'email': self.validated_data.get('email', '')
        }