Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't require file to be writeable if we're not going to write to it #281

Closed
wants to merge 2 commits into from

Conversation

jason-curtis
Copy link

closes #247

@hobu
Copy link
Member

hobu commented Sep 12, 2023

Please include some tests so this behavior doesn't regress again.

@jason-curtis
Copy link
Author

Unfortunately it turns out the same check is happening on the C library level as well: https://libspatialindex.org/en/latest/doxygen/DiskStorageManager_8cc_source.html#l00173

I'm hoping it's an overzealous check and write access isn't actually required but I can't be sure. In any case I'm not equipped to do a quick C side project right now so I'm going to work around the issue instead. I've checked in my latest implementation including (failing) unit tests; feel free to close this PR or take it over if you prefer.

@jason-curtis
Copy link
Author

jason-curtis commented Sep 13, 2023

In fact, since the C code is already doing its own checks and has reasonable error messages, maybe we should just remove these checks entirely from the Python implementation?

@mwtoews
Copy link
Member

mwtoews commented Sep 14, 2023

[repeating from linked issue] You could raise an issue and/or PR for libspatialindex; the source code on GitHub is here. But yeah, I agree that a fix from the library level would be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Index is checking write access despite assuming read-only access
3 participants