From 05a5d591df8061842cf3cee803897a457a734676 Mon Sep 17 00:00:00 2001 From: Dmitriy <54894715+Orlyanskiy93@users.noreply.github.com> Date: Tue, 10 Aug 2021 10:22:32 +0300 Subject: [PATCH 1/2] Update .swiftlint.yml add output rule to swiftlint --- xcode/.swiftlint.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/xcode/.swiftlint.yml b/xcode/.swiftlint.yml index df3de2ce..c024fb7a 100644 --- a/xcode/.swiftlint.yml +++ b/xcode/.swiftlint.yml @@ -264,6 +264,12 @@ custom_rules: regex: 'case[^\n\(]+\([^\)]*(let|var)\s' message: "Use a let|var keyword behind parentheses" severity: warning + + output_methods: + name: "Output methods" + regex: 'print|debugPrint|dump' + message: "Need to use os_log or swift-log for logging" + severity: error # Rx From 9ed1570907d74e5ef8efd0a4e79014d83d873383 Mon Sep 17 00:00:00 2001 From: Dmitriy <54894715+Orlyanskiy93@users.noreply.github.com> Date: Thu, 12 Aug 2021 14:53:57 +0300 Subject: [PATCH 2/2] Update .swiftlint.yml pr fix --- xcode/.swiftlint.yml | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/xcode/.swiftlint.yml b/xcode/.swiftlint.yml index c024fb7a..949a1914 100644 --- a/xcode/.swiftlint.yml +++ b/xcode/.swiftlint.yml @@ -126,12 +126,6 @@ custom_rules: message: "Do not use UIWebView. Use WKWebView Instead. https://developer.apple.com/reference/uikit/uiwebview" severity: error - native_print: - name: "print -> DDLog" - regex: '(print|NSLog)\(' - message: "Please use CocoaLumberjack instead `print` and `NSlog`" - severity: error - uiedge_insets_zero: name: "UIEdgeInsets .zero" regex: '\(top: 0, left: 0, bottom: 0, right: 0\)' @@ -265,11 +259,11 @@ custom_rules: message: "Use a let|var keyword behind parentheses" severity: warning - output_methods: - name: "Output methods" + logging_methods: + name: "Logging methods" regex: 'print|debugPrint|dump' - message: "Need to use os_log or swift-log for logging" - severity: error + message: "Use os or swift-log frameworks for logging" + severity: warning # Rx