-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Bluesky oEmbed auto-discovery #20028
Comments
Bluesky oembed should already be supported via the However looking at the oembed data returned it's missing a |
Hi @kevinansfield, thanks for the fast reply! Our intention is to set |
Ok, taking a look at the code it seems we don't have validation steps for "known" providers handled by the |
Great, thank you! We have |
closes TryGhost#20028 It's fairly common practice for oembed providers to skip some of the "required" fields from the oembed spec such as `height` when it doesn't make sense for the embeddable content, this was the case with Bluesky embeds which return `height: null` - removed validation for `height` being present in the response for it to be recognised as an embed because we don't use it anywhere and the validation is blocking otherwise valid embeds
Issue Summary
Bluesky (https://bsky.app) recently added post embeds, including oEmbed discovery.
For the later, it looks like Ghost does not allow the
<script>
tag to be auto-included, probably as a safety/security feature.From a quick check, it looks like Ghost uses
@extractus/oembed-extractor
to parse out oEmbed, and that package doesn't seem to work with the bluesky oEmbed discovery: https://extractor-demos.pages.dev/oembed-extractorIt looks like they synchronize with the "official" provider list at: https://oembed.com/providers.json
I opened an issue to get us on that provider list (iamcal/oembed#743).
I'm opening this issue in Ghost to confirm that this is the correct way to get supported in Ghost, and to track interoperability with Ghost specifically.
For what it is worth, the source code for our embed widget script, the embed.bsky.app service, and the Bluesky Social app itself are all open source: https://github.com/bluesky-social/social-app
Thanks for all you do maintaining Ghost!
Steps to Reproduce
Paste a bsky.app post link. Expect a fully-functional post (with JS/iframe). Instead get either a "card", or the raw embed
<blockquote>
without javascript re-write.Ghost Version
hosted
Node.js Version
hosted
How did you install Ghost?
hosted
Database type
MySQL 5.7
Browser & OS version
N/A
Relevant log / error output
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: