Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments from June 29 #12

Open
2 tasks done
mgelbart opened this issue Jun 29, 2018 · 1 comment
Open
2 tasks done

Comments from June 29 #12

mgelbart opened this issue Jun 29, 2018 · 1 comment

Comments

@mgelbart
Copy link
Member

mgelbart commented Jun 29, 2018

  • Refactor objective_functions.py so that everything is in functions rather in run on import of the .py file. It should be such that if I run with --synthetic then it's OK that the data files don't exist.
  • Delete non-adaptive lipo code (or move to another file where it's not in the way) - also, we discovered it's incorrect because it doesn't do the while loop thing to actually make n iterations.

For us to continue next time: figure out why it's now ridiculously slow. Maybe we can pick a test function and really dive in - reason about what parts of the space should be not rejected, etc. We'll have to come back to this.

@mgelbart
Copy link
Member Author

Regarding 34df14e, a keyword to look into is memoization. There are probably a few solutions to this issue that don't use a mess of global variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant