Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What happened with DataScaleFactor property for the PRW tool? #1174

Open
jbossios opened this issue Feb 27, 2018 · 3 comments
Open

What happened with DataScaleFactor property for the PRW tool? #1174

jbossios opened this issue Feb 27, 2018 · 3 comments

Comments

@jbossios
Copy link
Contributor

I remember that it was hardcoded at some point, but why remove it instead of making it configurable?

@ntadej
Copy link
Contributor

ntadej commented Feb 27, 2018

It was just renamed and changed into a map<string, float> (but after the discussion with @kratsg and @fscutti, the type of the output will change). In the previos form there was no way to specify different triggers to get DataPrescale for (just OR of all of them). If you can tell me your use-case I can adapt it efficiently for you or even return the default OR of all triggers.

@jbossios
Copy link
Contributor Author

Hi @ntadej

I'm not taking about prescaling factors but instead the "DataScaleFactor" property of the PileupReweighting tool:
https://twiki.cern.ch/twiki/bin/view/AtlasProtected/ExtendedPileupReweighting

Anyway, in my case even when I'm using prescaled triggers I don't care about prescale factors when I run with xAH because I calculate the corresponding luminosity of the OR of used triggers afterwards with a dedicated code.

Best,
Jona

@ntadej
Copy link
Contributor

ntadej commented Feb 27, 2018

Ah, yes, sorry 😊

Sure, we can make it configurable again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants