Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Issues in the Water Quality Module in Routing.py #4

Open
Aichumei opened this issue May 28, 2024 · 1 comment
Open

Possible Issues in the Water Quality Module in Routing.py #4

Aichumei opened this issue May 28, 2024 · 1 comment

Comments

@Aichumei
Copy link

I have identified a potential problem in the water quality module.
In the qualityRouting function of the routing.py file, the amount of pollutants transported downstream from each grid is calculated using "channelTransFrac" ( routing.py line 2754-2763) .
However, according to the calculateload module, each grid should have a pollutant load. If a grid does not contain a river, its “channelTransFrac” should be 0 (assuming my understanding of the module is correct). In this case, the load (e.g., domestic discharge) from that grid cannot be transferred to the downstream river. This might result in an underestimation of the pollution load entering the river.
I’m not sure if my understanding is correct.
Thank you for your reply!

@Aichumei
Copy link
Author

Aichumei commented Jun 6, 2024

I reviewed the code again and found that the channelStorage of each grid cell is directly contributed by the total runoff. Does this mean that the presence of a river in each grid cell is not important? Because I did not see any code identifying whether there is a river in the grid cell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant