Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merging pull requests #21

Open
5 tasks
awlevin opened this issue Sep 4, 2017 · 0 comments
Open
5 tasks

merging pull requests #21

awlevin opened this issue Sep 4, 2017 · 0 comments

Comments

@awlevin
Copy link
Member

awlevin commented Sep 4, 2017

Should explain the process of merging pull requests, highlighting:

  • Code review and commenting
  • Disapproving changes / Requesting changes from the contributor
  • Making the necessary changes and pushing new commits to master (show what this looks like in the Pull Request page)
  • Explain how sometimes a merge conflict will need to be resolved manually and pushed again (highlight that the pull request might/will close automatically [need to investigate this again]). Maybe include a hyperlink reference to the merge conflict section.
  • Approving changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@awlevin