Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markets Closing Functionality #276

Open
jfitz02 opened this issue Feb 27, 2025 · 0 comments
Open

Markets Closing Functionality #276

jfitz02 opened this issue Feb 27, 2025 · 0 comments
Labels
bug Something isn't working enhancement Improvement to existing command/feature

Comments

@jfitz02
Copy link
Contributor

jfitz02 commented Feb 27, 2025

Currently using /close_market will simply calculate pnl and display the output... That's it

It would be nice if the market is actually "closed" i.e. you can't trade on it anymore.

For now it may be ok to simply delete the market from the market dict after closing, but what if we want to look back at previous markets? - This is likely a future issue with storing trade history
@jfitz02 jfitz02 added bug Something isn't working enhancement Improvement to existing command/feature labels Feb 27, 2025
alimmeek added a commit that referenced this issue Feb 28, 2025
@alimmeek
Added close market fuctionality as per #276
1559ba1
alimmeek added a commit that referenced this issue Feb 28, 2025
@alimmeek
Added close market fuctionality as per #276 (#277)
a1f971f 
* Added close market fuctionality as per #276

* Fixed error where I wrote C instead of Python (oopsies)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement Improvement to existing command/feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jfitz02