Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FitSettingsDialog class should support several FitContainer instances #454

Open
Neverhorst opened this issue Nov 28, 2018 · 0 comments
Open

FitSettingsDialog class should support several FitContainer instances #454

Neverhorst opened this issue Nov 28, 2018 · 0 comments
Labels
comp:fit_logic design issue

Comments

@Neverhorst
Copy link
Member

What is affected by this bug?

FitSettingsDialog can only control/configure a single FitContainer instance.

When does this occur?

When trying to use multiple FitContainer instances in a measurement logic you only want a single FitSettingsDialog to configure them all simultaneously.

Where on the platform does it happen?

FitSettingsDialog.__init__ only takes a single FitContainer

Expected behavior (i.e. solution)

FitSettingsDialog.__init__ could optionally take an iterable containing FitContainer instances. Most instance methods would need to be adjusted to this change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp:fit_logic design issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Neverhorst