Simple.js adds undefined as a placeholder where no placeholder attribute exists

[adrianosmond]

No description provided.

[replete]

I'm having the same issue. Adding an empty 'placeholder' attribute does the trick for now, but superfluous.

Feels like it should be a straightforward fix, if I find sometime next week I might investigate further.

[kbjr]

I'm happy to accept a PR, but I don't really have time to look into myself.

[replete]

I investigated a bit further, and made the following modification which changes behaviour like so:

• Ignores [type=password], because shimmed placeholder text is obfuscated with the password circles
• Ignores <textarea>, because textarea doesn't support placeholders and it wasn't checking for existance of a [placeholder] attribute.

New isValidElement function:

function isValidElement(elem) {
        var tag = (elem.nodeName || '').toLowerCase();
        return (tag !== 'textarea' && (tag === 'input' && (elem.type === 'text' || elem.type !== 'password')));
    }

I spent a little while adding logic for .getAttribute('placeholder'), but ran into problems only reading getAttribute() for valid elem. For some reason MutationEvent elem variables were coming through, and I ran into issues making the logic (x instanceof y etc) work well in IE7+.

I only need IE9 so I'll leave it as is for now.