Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new filter for notifications: event-type #355

Closed
hmpf opened this issue Mar 3, 2022 · 2 comments · Fixed by #466
Closed

Add new filter for notifications: event-type #355

hmpf opened this issue Mar 3, 2022 · 2 comments · Fixed by #466
Assignees
@johannaengland
Labels
API v2 Ideas for API v2, backwards incompatible OK API Affects Argus' REST API discussion Requires developer feedback/discussion before implementation enhancement New feature or request filter Affects the Filter-model, incident list query parameters or both frontend Affects frontend

Comments

@hmpf
Copy link
Contributor

hmpf commented Mar 3, 2022

Maybe we only want alerts about START-events, as an example.
@hmpf
Copy link
Contributor Author

hmpf commented Mar 3, 2022

See #206

@hmpf hmpf added API Affects Argus' REST API API v2 Ideas for API v2, backwards incompatible OK enhancement New feature or request filter Affects the Filter-model, incident list query parameters or both frontend Affects frontend labels Mar 3, 2022
@lunkwill42
Copy link
Member

An event-type filter would be specific to a notification subscription, not to filters that are used in the dashboard.

@hmpf hmpf added the discussion Requires developer feedback/discussion before implementation label Aug 10, 2022
@johannaengland johannaengland self-assigned this Aug 30, 2022
@johannaengland johannaengland mentioned this issue Aug 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johannaengland johannaengland

Labels
API v2 Ideas for API v2, backwards incompatible OK API Affects Argus' REST API discussion Requires developer feedback/discussion before implementation enhancement New feature or request filter Affects the Filter-model, incident list query parameters or both frontend Affects frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add new filter for notifications: event-type johannaengland/Argus
3 participants
@lunkwill42 @hmpf @johannaengland