Skip to content

Commit b973fd4

Browse files
author
attardi
committed
Quiet logging.
1 parent 4290b00 commit b973fd4

File tree

4 files changed

+16
-18
lines changed

4 files changed

+16
-18
lines changed

Makefile

+8-11
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ else ifeq ($(LANG), fr)
7979
else ifeq ($(LANG), it)
8080
CORPUS=it_isdt
8181
RES2=Italian-ISDT
82-
MODEL = --bert= dbmdz/bert-base-italian-xxl-cased
82+
MODEL = --bert=dbmdz/bert-base-italian-xxl-cased
8383
BERT = dbmdz-xxl
8484
else ifeq ($(LANG), lt)
8585
CORPUS=lt_alksnis
@@ -146,9 +146,11 @@ endif
146146
.PRECIOUS: exp/$(LANG)-$(FEAT)$(VER)/model
147147

148148
# relate LANG to CORPUS
149-
exp/$(LANG)%: exp/$(CORPUS).$(BERT)%
149+
exp/$(LANG)%: exp/$(CORPUS).$(BERT)$(VER)%
150150
@:
151151

152+
TARGET=exp/$(CORPUS).$(BERT)$(VER)
153+
152154
exp/$(CORPUS).$(BERT)$(VER)/model:
153155
python -u -m diaparser.cmds.biaffine_dependency train -d=$(GPU) -p=$@ \
154156
-c=$(CONFIG) $(MODEL) $(ATTN) \
@@ -161,11 +163,6 @@ exp/$(CORPUS).$(BERT)$(VER).test.conllu: exp/$(CORPUS).$(BERT)$(VER)/model
161163
--pred=$@
162164
python $(CORPUS_DIR)/fix-root.py $@
163165

164-
exp/$(CORPUS).$(BERT)$(VER).test.time: exp/$(CORPUS).$(BERT)$(VER)/model
165-
( time python -m diaparser.cmds.biaffine_dependency predict -d=$(GPU) -p=$< --feat=$(FEAT) --tree \
166-
$(BLIND_TEST) \
167-
--pred=/dev/null; ) &> $@
168-
169166
LANGS=ar bg cs en et fi fr it lt lv nl pl ru sk sv ta uk
170167
LANGS1=ar bg en et fi sk
171168
LANGS2=fr it ru ta uk sv
@@ -184,16 +181,16 @@ train:
184181
# ----------------------------------------------------------------------
185182
# Evaluation
186183

187-
%.test.nen.conllu: %.test.conllu
184+
$(TARGET).test.nen.conllu: $(TARGET).test.conllu
188185
perl $(UD_TOOLS)/enhanced_collapse_empty_nodes.pl $< > $@
189186

190-
%.test.eval: %.test.nen.conllu
187+
$(TARGET).test.eval: $(TARGET).test.nen.conllu
191188
python $(UD_TOOLS)/iwpt20_xud_eval.py -v $(UD_TOOLS)/../test-gold/$(LANG).nen.conllu $< > $@
192189

193-
%.test.evalb: %.test.eval
190+
$(TARGET).test.evalb: $(TARGET).test.eval
194191
python $(CORPUS_DIR)/eval.py -g $(GOLD_TEST) -s $@ --evalb
195192

196-
%.test.eval07: %.test.conllu
193+
$(TARGET).test.eval07: $(TARGET).test.conllu
197194
perl $(CORPUS_DIR)/eval07.pl -p -q -g $(GOLD_TEST) -s $< > $@
198195

199196
evaluate:

diaparser/cmds/biaffine_dependency.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
from ..parsers import BiaffineDependencyParser
88
from .cmd import parse
9-
9+
import os
1010

1111
def main():
1212
parser = argparse.ArgumentParser(description='Create Biaffine Dependency Parser.')
@@ -45,7 +45,7 @@ def main():
4545
subparser.add_argument('--pred', default='pred.conllx', help='path to predicted result')
4646
subparser.add_argument('--text', metavar='LANGUAGE', default=None,
4747
help='parse plain text in the given language rather than CoNLL-U files.')
48-
subparser.add_argument('--cache-dir', default='~/.cache/parser',
48+
subparser.add_argument('--cache-dir', default=os.path.expanduser('~/.cache/diaparser'),
4949
help='path to saved parser/tokenizer models')
5050
parse(parser)
5151

diaparser/cmds/cmd.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ def parse(argparser):
2222
torch.set_num_threads(args.threads)
2323
torch.manual_seed(args.seed)
2424
init_device(args.device)
25-
init_logger(logger, f"{args.path}.{args.mode}.log")
25+
init_logger(logger, f"{args.path}.{args.mode}.log", verbose=args.verbose)
2626
logger.info('Configuration:\n' + str(args))
2727

2828
if args.mode == 'train':

tokenizer/tokenizer.py

+5-4
Original file line numberDiff line numberDiff line change
@@ -29,19 +29,20 @@ def format(self, sentences):
2929
"""
3030
Convert sentences to TSV format.
3131
"""
32+
empty_fields = '\t_' * 8
3233
for i, sentence in enumerate(sentences):
3334
yield f'# sent_id = {i+1}'
3435
sent_text = sentence.text.replace("\n", " ")
3536
yield f'# text = {sent_text}'
3637
for token in sentence.tokens:
3738
# multiword
3839
if len(token.words) > 1:
39-
token_ids = '-'.join([str(id) for id in token.id])
40-
yield f'{token_ids}\t{token.text}'
40+
token_range = f'{token.id[0]}-{token.id[-1]}'
41+
yield f'{token_range}\t{token.text + empty_fields}'
4142
for word in token.words:
42-
yield f'{word.id}\t{word.text}'
43+
yield f'{word.id}\t{word.text + empty_fields}'
4344
else:
44-
yield f'{token.id[0]}\t{token.text}'
45+
yield f'{token.id[0]}\t{token.text + empty_fields}'
4546
yield ''
4647

4748
def reader(self):

0 commit comments

Comments
 (0)