Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifications and enhancements #1

Open
ddTech opened this issue Nov 24, 2017 · 2 comments
Open

Modifications and enhancements #1

ddTech opened this issue Nov 24, 2017 · 2 comments

Comments

@ddTech
Copy link
Collaborator

ddTech commented Nov 24, 2017

When I sat in Doug's session of last week's DevCon in Frankfurt I remembered that I have done modifications to the class. And as I now looked through my code, I found that it actually was guite a bit I did back then.
No idea, why I did not publish it at that time. Maybe the next project was calling for attention and later contribution became difficult, as most of the stuff was done in 2011, when version 1.30 Alpha was current, which is the version I'm still working with.
But as we now have Git, I guess what I should do, is to fork the current branch and see if I can adopt my modifications to the current version - as far as they have not already been implemented by now.

In theory we then should be able to merge that into the new version.
I have been using Git for years, but up to now only as a consumer. So I'm not too familiar with the way it works. However I doubt that it is able to deal with our vcx/vct and scx/sct files. Prgs should be no problem.
If I see it right, there are also sourceSafe-Files (vca / sca). Having them here is a bit like "belt and suspenders", but as those files are in fact the flat file representations of our propritetary formats, this might be the way to go. I am using SourceSafe as well.
I'll write an individual "issue" for each modification/idea/remark I made. I think this is better than one longer writeup and makes it easier for us to discuss whether the one or the other is worth being ported into the current version or if I'm on the wrong track. OK?

regards

Frank

@DougHennig
Copy link
Member

Hi Frank.

I don't think Cesar is doing anything with GitHub yet, so why not create a pull request with your changes or even just do a commit and push so your changes are merged into the repository?

Doug

@ddTech
Copy link
Collaborator Author

ddTech commented Dec 12, 2017

Hi Doug,

I'll have to port my changes to the current version first. It's all in Version 1.30 Alpha right now.
If that works, I can do the pull or commit.

Best regards

Frank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants