Refactor: GET_ORDERED_ALL_CHARACTERS_INFOを統合 #1819
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevenc-nanashi
requested review from
Hiroshiba
and removed request for
a team
Hiroshiba
reviewed
Feb 3, 2024
Hiroshiba
reviewed
Feb 4, 2024
Comment on lines
166
to
170
| // サンプルの順番、新しいキャラクターは上に | ||
| sampleCharacterOrder.value = [ | ||
| ...newCharacters.value, | ||
| ...props.characterInfos | ||
| ...characterInfosArray.value | ||
| .filter( |
There was a problem hiding this comment.
こーーーーーーれ、characterInfosArrayはorderedな必要がある気がしてきました･･･････。
（順番が大事っぽい。）
Comment on lines
169
to
173
| <default-style-list-dialog | ||
| v-if="orderedTalkCharacterInfos.length > 0" | ||
| v-if="allTalkCharacterInfos.length > 0" | ||
| v-model="isDefaultStyleSelectDialogOpenComputed" | ||
| :character-infos="orderedTalkCharacterInfos" | ||
| :character-infos="allTalkCharacterInfos" | ||
| /> |
There was a problem hiding this comment.
こっちも実はorderedじゃないといけない説が･･･････？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
速度的にもあまり変わらない（ソース）ので統合します。
関連 Issue
（なし）
スクリーンショット・動画など
（なし）
その他
（なし）