Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate: optional chainに書き換える #2387

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

sevenc-nanashi
Copy link
Member

内容

github-linguist/linguist#7138

?. を使ってもハイライトが崩れなくなったのでそれを使うようにします。

関連 Issue

(なし)

スクリーンショット・動画など

IMG_3862

その他

(なし)

@sevenc-nanashi sevenc-nanashi requested a review from a team as a code owner December 3, 2024 15:14
@sevenc-nanashi sevenc-nanashi requested review from Hiroshiba and removed request for a team December 3, 2024 15:14
@voicevox-preview-pages
Copy link

voicevox-preview-pages bot commented Dec 3, 2024

🚀 プレビュー用ページを作成しました 🚀

更新時点でのコミットハッシュ:1319d5e

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

ようやくですね!!!!! 依存が減って嬉しい!!!

@Hiroshiba Hiroshiba merged commit 02ac972 into VOICEVOX:main Dec 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants