Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected element on navbar needs to be more visible #29

Closed
AndersonCeci opened this issue Oct 11, 2023 · 3 comments
Closed

Selected element on navbar needs to be more visible #29

AndersonCeci opened this issue Oct 11, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@AndersonCeci
Copy link

Screencast.from.11.10.23.01.01.05.MD.CEST.webm

I don't know if this is intentional, but it can be done better if you can assign me this issue I can help with it

@Acumane
Copy link
Member

Acumane commented Oct 13, 2023

Duplicate #13

Home and about buttons are just placeholders demoing Vue Routing. We should have a conversation about what kind of buttons/pages should be (e.g. settings page?)

@mattsweet417 had some thoughts on this in #28, and concepts can be found in #4

The two of you should collaborate if possible given the overlap. Also keep in mind CRN search will have an element in the navbar

@Acumane
Copy link
Member

Acumane commented Oct 13, 2023

I'll keep this one open since you'll be assigned to it

@Acumane Acumane added the enhancement New feature or request label Oct 13, 2023
@mattsweet417
Copy link
Member

mattsweet417 commented Oct 15, 2023

In #28 I am completely overhauling the nav bar, getting rid of the home and about links and relying on clickable icons. I also got rid of the about page entirely because the team thought it was redundant to the github and not needed. You can see the changes on the 28-edit-links-on-navbar branch.

@Acumane Acumane closed this as completed Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants