New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decision_sender_create function definition is dead code #208

Open

SchuylerGoodman opened this issue Oct 14, 2020 · 1 comment

Contributor

SchuylerGoodman commented Oct 14, 2020

It looks like this line is dead code, since DECISION_SENDER was removed in commit #189 (@olgavrou ?)

reinforcement_learning/rlclientlib/azure_factories.cc

Line 16 in 6f4600f

    
           int decision_sender_create(i_sender** retval, const u::configuration&, error_callback_fn*, i_trace* trace_logger, api_status* status);

Collaborator

olgavrou commented Oct 16, 2020

@SchuylerGoodman yes it looks like that should be removed also, thanks for pointing it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment