Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rl.cli.net] logs are not generated when configured to produce them locally. #384

Open
kumpera opened this issue Jul 30, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@kumpera
Copy link
Contributor

kumpera commented Jul 30, 2021

I'm using this rl.net.cli command:

dotnet .\Rl.Net.Cli.dll perf --actions 50 --shared-features 3 --action-features 10  --data 1 --config client.json

With the following client.json:

{
    "ApplicationID": "cf8a74ffaa1f4d1a872d251909bfa77d",
    "observation.file.name": "C:\\joiner-data\\observations.fb",
    "interaction.file.name": "C:\\joiner-data\\interactions.fb",
    "model.source": "NO_MODEL_DATA",
    "interaction.sender.implementation": "INTERACTION_FILE_SENDER",
    "observation.sender.implementation": "OBSERVATION_FILE_SENDER",
    "decisions.sender.implementation": "INTERACTION_FILE_SENDER",
    "InitialExplorationEpsilon": 1.0,
    "LearningMode": "Online",
    "queue.mode" : "BLOCK",
    "protocol.version": "2",
    "send.batchintervalms": "10000"
  }

No data is produced and no error is reported after 10 minutes.

@kumpera kumpera added the bug Something isn't working label Jul 30, 2021
@ataymano
Copy link
Member

logger is turned off by default.
adding:
"trace.logger.implementation": "CONSOLE_TRACE_LOGGER"
should help you to get more logs

@kumpera kumpera added enhancement New feature or request and removed bug Something isn't working labels Aug 2, 2021
@kumpera
Copy link
Contributor Author

kumpera commented Aug 2, 2021

I did troubleshoot it further and here my findings.

This happens on windows only.
The issue is a mix of the following:

  • rlclientlib opens the result file in exclusive mode, which leads to windows not showing the file size until the end.
  • rl.net.cli even when in data size mode, it reports progress in terms of number of decisions.

This means there's no reasonable way to assess how far a run is, which is not particularly helpful when you have a run that could take close to an hour.

The outcome of this investigation is that rl.net.cli should report progress by the same unit it will terminate execution and maybe show completion percentages for those of us that are both impatient and anxious.

Whether rl.client.lib should open the output file in shared more or not is a more complex question as it deviates from the standard open mode in windows and I can't easily tell what could go wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants