Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Twitch Connection Token Does Not Include Account Name #1300

Closed
StreetCatLove opened this issue Jan 27, 2025 · 7 comments · May be fixed by #1302
Closed

[Bug] Twitch Connection Token Does Not Include Account Name #1300

StreetCatLove opened this issue Jan 27, 2025 · 7 comments · May be fixed by #1302

Comments

@StreetCatLove
Copy link

Operating System Info

Windows 10

Other OS

No response

OBS Studio Version

31.0.1

Advanced Scene Switcher Version

1.28.1

Plugin settings

No response

OBS Studio Log URL

No response

OBS Studio Crash Log URL

No response

Expected Behavior

When connecting a twitch account, the token should come back with an account name, allowing the account connection to form.

Current Behavior

When connecting a twitch account, the token does not come back with an account name, stopping the account connection from forming.

Image

The only related log I can see with verbose logging enabled is:
[adv-ss] failed to get Twitch user id from token!

Steps to Reproduce

  1. On Edge/Firefox, clear cookies/data and log into twitch
  2. Add new twitch connection and hit connect account button
  3. Browser authenticates with twitch, displaying "Authentication successful! You can close this window now."
  4. token is entered in Advanced Scene Switcher but no account name is shown. you are unable to enter an account name or proceed.

Image

Anything else we should know?

No response

@StreetCatLove StreetCatLove changed the title Twitch Connection Token Does Not Include Account Name [Bug] Twitch Connection Token Does Not Include Account Name Jan 27, 2025
@StreetCatLove
Copy link
Author

StreetCatLove commented Jan 27, 2025

I tried chrome as well on the w10 machine and the result was the same.
My w11 machine with OBS 31.0.1 / ADVSS 1.26.4 and later 1.28.1 was successful in linking using firefox and chrome, however there is a message by the account name that says "Empty name not allowed!".

the related verbose log in this w11 case is:
16:45:02.285: [adv-ss] Twitch GET request to https://api.twitch.tv/helix/users?login= began
16:45:02.530: ignoring invalid channel selection ''!

Image

Please let me know if there is any additional logs or test I can do to assist.

@WarmUpTill
Copy link
Owner

WarmUpTill commented Jan 29, 2025

Thanks for reporting the problems!

To be honest I am not sure what exactly went wrong in the initial screenshot you shared.
Here GET request to "https://api.twitch.tv/helix/users" failed for some reason.
Without knowing the username associated with the token the plugin will not allow you to store the connection.
I am not sure why that GET request would fail.

Were you using the same account as in the second screenshot?
Were you using the Twitch API extensively during that time period? (Probably difficult to say)
Could you find any messages similar to Twitch request failed in %s with error: %s in the log?


I am able to replicate the issue of the "Empty name not allowed!" warning is showing up incorrectly.
This UI issue will be fixed in the linked PR.
A build will be available here in a few minutes:
https://github.com/WarmUpTill/SceneSwitcher/actions/runs/13038343850?pr=1302

@StreetCatLove
Copy link
Author

StreetCatLove commented Jan 29, 2025

I've tried two different accounts on both machines and got the same results. I was running my 24/7 stream and using the "Transparent Twitch Chat Overlay" program to display chat on-stream at the time when I found the issue and my initial testing, though now I also have a python script running to replace the chat reading functionality.

Searching the obs logs for "twitch request failed" got no hits.

@StreetCatLove
Copy link
Author

To satisfy my curiosity i spun up a w10 vm on my w11 machine and did not have any problems connecting. Since it seems not possible to replicate, hard to test while keeping my stream going, and easy for me to keep functionality going with a python script utilizing twitchio library, I will close.

@StreetCatLove StreetCatLove closed this as not planned Won't fix, can't repro, duplicate, stale Jan 29, 2025
@Hoempah
Copy link

Hoempah commented Jan 31, 2025

I got the same problem. Tried the PR but still fails.
Maybe because i switched to using only the streamkey and not using account login.

[adv-ss] failed to get Twitch user id from token!

@WarmUpTill
Copy link
Owner

@Hoempah the PR only fixes the UI issue showcased in the comment from StreetCatLove.
It does not change any underlying functionality.

Do you happen to have a log file with verbose logging enabled?

@Hoempah
Copy link

Hoempah commented Feb 1, 2025

I only see this line: 16:19:35.114: [adv-ss] failed to get Twitch user id from token!
When chrome opens i get the message that it was successful and i can close the browser.

Image

Image

Image

2025-02-01 16-18-25.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants