Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSocket connections are not exported/imported when using export string #1305

Open
KaDokta opened this issue Feb 6, 2025 · 1 comment
Open

Comments

@KaDokta
Copy link

KaDokta commented Feb 6, 2025

Operating System Info

Windows 10

Other OS

No response

OBS Studio Version

31.0.1

Advanced Scene Switcher Version

1.27.2

Plugin settings

No response

OBS Studio Log URL

No response

OBS Studio Crash Log URL

No response

Expected Behavior

Importing macros into the macro list should automatically add any required WebSocket connections, just like it automatically adds any variables used. Exporting should automatically add any used connections to the export string.

Current Behavior

Importing the macros provided into the macro list does not automatically add the required WebSocket connections if they happen to use one. The connection has to be manually added/selected for each macro. Exporting does not automatically add the connection to the export string.

Steps to Reproduce

  1. Paste example export string into macro list { "macros": [ { "name": "TestMacro", "group": false, "conditions": [], "actions": [ { "id": "websocket", "type": 0, "api": 2, "message": "Test", "connection": "TestConnection" } ] } ], "websocketConnections": [ { "name": "TestConnection", "useCustomURI": true, "customURI": "ws://localhost:3001/test", "useOBSWSProtocol": false, "connectOnStart": true, "reconnect": true } ], "variables": [{ "name": "TestVariable", "saveAction": 0, "defaultValue": "" }] }
  2. WebSocket connection is not automatically added. Variables are automatically added.

Anything else we should know?

Could be considered a feature request, but since it works for variables, I set it as a bug for now.

Also, if the implementation proves difficult and time consuming, it would already help if the "WebSocket Connections" tab is visible by default, so you can add one before importing the macros.

@WarmUpTill
Copy link
Owner

This was done intentionality to avoid accidentally leaking connection secrets when sharing macros.
(Same applies for Twitch connections)

The connection details are still exported when saving settings to a file.

I might look into adding the option to also include those details.
Unfortunately I am currently a bit short on time I have available for the plugin development, so I can't give you an ETA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants