Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I get thread safety check from CaptureSessionManager #380

Closed
sami79031 opened this issue Mar 28, 2024 · 4 comments
Closed

I get thread safety check from CaptureSessionManager #380

sami79031 opened this issue Mar 28, 2024 · 4 comments
Labels
good first issue Good for newcomers Stale

Comments

@sami79031
Copy link

That happens almost every time I start the ImageScannerController. I'm using it from the SwiftUI context iOS 16. Nothing special.

-[AVCaptureSession startRunning] should be called from background thread. Calling it on the main thread can lead to UI unresponsiveness

Screenshot 2024-03-28 at 6 37 55 PM
@BasThomas BasThomas added the good first issue Good for newcomers label Apr 16, 2024
@BasThomas
Copy link
Contributor

BasThomas commented Apr 16, 2024

Thanks for opening an issue! Would you want to try and tackle this by opening a pull request? :)

Sounds like we don't need / want the DispatchQueue.main.async here.

@gantaa
Copy link

gantaa commented May 12, 2024

I was in the process of creating a PR to contribute for this because I am also seeing the log on latest WeScan code. But then I saw this:

699b747

It looks like the correct code for this fix. It is committed to master, and yet I still see the log appear when using WeScan 3.0.0

Any ideas @BasThomas or @hajunho?

@BasThomas
Copy link
Contributor

3.0.0 does not include the changes present on the main branch. Can you update your reference to be the main branch rather than 3.0.0, to see if the issue is still present then? We can look into creating a new release from there.

Copy link

This issue is stale because it has been open for 30 days with no activity. Remove the Stale label or comment or this will be closed in 10 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Stale
Projects
None yet
Development

No branches or pull requests

3 participants