Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A little suggestion. #384

Closed
JunkyTang opened this issue Jul 8, 2024 · 2 comments
Closed

A little suggestion. #384

JunkyTang opened this issue Jul 8, 2024 · 2 comments
Labels

Comments

@JunkyTang
Copy link

Since this library is written in Swift, would it be more appropriate to change NSObjectProtocol to AnyObject here in the
public protocol ImageScannerControllerDelegate: NSObjectProtocol?

This way, my class public class App {} can conform to your protocol.

@BasThomas
Copy link
Contributor

Thanks for bringing this up, @JunkyTang! That sounds reasonable; I'd encourage you to open a pull request for this change!

Copy link

github-actions bot commented Aug 8, 2024

This issue is stale because it has been open for 30 days with no activity. Remove the Stale label or comment or this will be closed in 10 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants