-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
M4V support #139
Comments
Isn't MV4 a subset of MPEG4 and thus effectively MOV? The parser we have should be picking it up. |
I.e. it should be supported via https://github.com/WeTransfer/format_parser/blob/master/lib/parsers/moov_parser.rb or it should be relatively within reach to make sure it is supported |
I didn't knew this, but I just learned that is the case indeed. It is like a MOV. I guess it requires some minor changes to the |
As m4v is already part of the mov family, it already parses this information successfully. However it's not included in the likely matches. This PR takes care of that. Closes #139
Follow up from #138
Currently in Spaceship we have a video thumbnailer. In Spaceship we check the file extension instead of actually using the format parser (mainly because changing the file extension on mobile is quite uncommon). However, we still have plans to use the format parser for this, if only it supported M4V formats.
Related: WeTransfer/spaceship#1975
The text was updated successfully, but these errors were encountered: