Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not parse mp3 files with id3 v2.4.x #168

Closed
fabioperrella opened this issue Sep 22, 2020 · 0 comments · Fixed by #169
Closed

Does not parse mp3 files with id3 v2.4.x #168

fabioperrella opened this issue Sep 22, 2020 · 0 comments · Fixed by #169
Assignees
@fabioperrella
Labels
bug

Comments

@fabioperrella
Copy link
Contributor

MP3Parser skips MP3 files which has id3 version 2.4.x:

ID3V2_TAG_VERSIONS = ["\x43\x00".b, "\x03\x00".b, "\x02\x00".b]
# ...
return unless ID3V2_TAG_VERSIONS.include?(header[:version])

From what I understand, these versions are 2.2.0, 2.3.0 and 2.67.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fabioperrella fabioperrella

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MP3: add suport to id3 v2.4.x WeTransfer/format_parser
1 participant
@fabioperrella