Skip to content

Binaryen doesn't update .debug_addr section #3460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bmeurer opened this issue Dec 23, 2020 · 1 comment
Closed

Binaryen doesn't update .debug_addr section #3460

bmeurer opened this issue Dec 23, 2020 · 1 comment

Comments

@bmeurer
Copy link

bmeurer commented Dec 23, 2020

Downstream issue: emscripten-core/emscripten#13099
Chromium issue: https://crbug.com/1161422

Repro is on the downstream issue, the problem is that .debug_addr isn't updated by the DWARF support in Binaryen.

bmeurer added a commit to bmeurer/binaryen that referenced this issue Dec 23, 2020
This is a minimal patch to add support for also updating the addresses
stored in the .debug_addr DWARF section, which is used to perform
address resolution at debug time with debug fission. This is minimal in
the sence that it only supports the pre-DWARFv5 .debug_addr format that
is emitted by Emscripten currently, and which only consists of a simple
list of addresses.

Ideally the copy of DWARFYAML in the Binaryen tree should be updated
with LLVM ToT at some point, which will provide full support for DWARFv5
index tables, including the new .debug_addr format.

Ref: WebAssembly#3460
Ref: emscripten-core/emscripten#13099
Bug: https://crbug.com/1161422
bmeurer added a commit to bmeurer/binaryen that referenced this issue Dec 23, 2020
This is a minimal patch to add support for also updating the addresses
stored in the .debug_addr DWARF section, which is used to perform
address resolution at debug time with debug fission. This is minimal in
the sence that it only supports the pre-DWARFv5 .debug_addr format that
is emitted by Emscripten currently, and which only consists of a simple
list of addresses.

Ideally the copy of DWARFYAML in the Binaryen tree should be updated
with LLVM ToT at some point, which will provide full support for DWARFv5
index tables, including the new .debug_addr format.

Ref: WebAssembly#3460
Ref: emscripten-core/emscripten#13099
Bug: https://crbug.com/1161422
bmeurer added a commit to bmeurer/binaryen that referenced this issue Dec 23, 2020
This is a minimal patch to add support for also updating the addresses
stored in the .debug_addr DWARF section, which is used to perform
address resolution at debug time with debug fission. This is minimal in
the sence that it only supports the pre-DWARFv5 .debug_addr format that
is emitted by Emscripten currently, and which only consists of a simple
list of addresses.

Ideally the copy of DWARFYAML in the Binaryen tree should be updated
with LLVM ToT at some point, which will provide full support for DWARFv5
index tables, including the new .debug_addr format.

Ref: WebAssembly#3460
Ref: emscripten-core/emscripten#13099
Bug: https://crbug.com/1161422
@tlively
Copy link
Member

tlively commented Jan 14, 2025

From the discussion on the linked PR, it sounds like there is no way to correctly update this section, so I'll close this issue.

@tlively tlively closed this as completed Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants