-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
should memory be exported as well? #22
Comments
As a reference point, emscripten has been shipping multi-threaded apps based on workers (instance-per-thread) for a while now, and the shared memory is always imported by the module in this case (and never exported). |
@sunfishcode and I had talked some time ago about switching the WASI paradigm from "export the memory" to "import the memory." It might break some things but I would recommend discussing that over in the WASI repository and seeing if that change can be made now before too many things depend on that fact. |
it makes sense. i created an issue there. WebAssembly/WASI#502 |
While it's a bit redundant to both import and export a memory, it's what WASI implementations expect. Import alone is fine but export wouldn't hurt: Emscripten, toywasm Export is checked: wasm-micro-runtime Export is necessary?: wasmtime References: https://github.com/WebAssembly/WASI/blob/main/legacy/application-abi.md#current-unstable-abi WebAssembly#22
While it's a bit redundant to both import and export a memory, it's what WASI implementations expect. Emscripten, toywasm: Import alone is fine. But export wouldn't hurt. wasm-micro-runtime: Export is checked. Nothing actually seems to rely on it though. wasmtime: Export is necessary? References: https://github.com/WebAssembly/WASI/blob/main/legacy/application-abi.md#current-unstable-abi WebAssembly#22
While it's a bit redundant to both import and export a memory, it's what WASI implementations expect. Emscripten, toywasm: Import alone is fine. But export wouldn't hurt. wasm-micro-runtime: Export is checked. Nothing actually seems to rely on it though. wasmtime: Export is necessary? References: https://github.com/WebAssembly/WASI/blob/main/legacy/application-abi.md#current-unstable-abi WebAssembly#22
While it's a bit redundant to both import and export a memory, it's what WASI implementations expect. Emscripten, toywasm: Import alone is fine. But export wouldn't hurt. wasm-micro-runtime: Export is checked. Nothing actually seems to rely on it though. wasmtime: Export is necessary? References: https://github.com/WebAssembly/WASI/blob/main/legacy/application-abi.md#current-unstable-abi WebAssembly#22
While it's a bit redundant to both import and export a memory, it's what WASI implementations expect. Emscripten, toywasm: Import alone is fine. But export wouldn't hurt. wasm-micro-runtime: Export is checked. Nothing actually seems to rely on it though. wasmtime: Export is necessary? References: https://github.com/WebAssembly/WASI/blob/main/legacy/application-abi.md#current-unstable-abi WebAssembly#22
discussions:
WebAssembly/wasi-libc#369 (comment)
#19 (comment)
WebAssembly/WASI#48 (comment)
The text was updated successfully, but these errors were encountered: